You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2015/11/25 06:23:31 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-460 Modify style.css for...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/469
ZEPPELIN-460 Modify style.css for the aesthetically pleasant document…
I modified style.css file (located in /docs/assets/themes/zeppelin/css/style.css).
The result of this PR is like below attached images.
1. Resize hn tag font & Add bottom-border to h2, h3 tag (Because these tags are used a lot for the title.)
- Before
- After
2. Change code color & Arrange code font size
3. Change Code font-family and reduce the font size
4. Increase padding size between p, block quote, table, pre, img
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-460
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #469
----
commit cd55fe7ea30ea2c1d652264474af9501360444e1
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-11-25T05:14:48Z
ZEPPELIN-460 Modify style.css for the aesthetically pleasant documentation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-460 Modify style.css for...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/469#issuecomment-159534480
I like the new font size/spacing code block but it seems the color style is a bit different?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-460 Modify style.css for...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/469#issuecomment-159537139
Thank you for your review @felixcheung : )
You mean the small code block ?
The red color seems like little bit aggressive, so I changed to black like other open source project documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-460 Modify style.css for...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/469#issuecomment-159552857
Cool. A lot better than before. Thank you so much.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-460 Modify style.css for...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/469#issuecomment-159673870
Looks great, but if its possible not to make fonts smaller - for me that would be even more awesome.
Mobile devices do not tolerate small fonts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-460 Modify style.css for...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---