You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/25 12:11:42 UTC
[GitHub] [hudi] Baibaiwuguo opened a new pull request, #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Baibaiwuguo opened a new pull request, #5423:
URL: https://github.com/apache/hudi/pull/5423
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
hudi-spark-bundle miss avro. I repair it.
*(For example: This pull request adds quick-start document.)*
## Brief change log
- hudi-spark-bundle add avro dependency
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5423:
URL: https://github.com/apache/hudi/pull/5423#issuecomment-1115295390
@Baibaiwuguo can you please add more details in the PR and the Jira explaining the issues you're having right now, steps to reproduce?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5423:
URL: https://github.com/apache/hudi/pull/5423#issuecomment-1108672404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7fa04a277661c65b4f7faa48f0b69b39a7cee9a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8291",
"triggerID" : "a7fa04a277661c65b4f7faa48f0b69b39a7cee9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7fa04a277661c65b4f7faa48f0b69b39a7cee9a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5423:
URL: https://github.com/apache/hudi/pull/5423#issuecomment-1108530150
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7fa04a277661c65b4f7faa48f0b69b39a7cee9a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8291",
"triggerID" : "a7fa04a277661c65b4f7faa48f0b69b39a7cee9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7fa04a277661c65b4f7faa48f0b69b39a7cee9a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8291)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Baibaiwuguo closed pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
Baibaiwuguo closed pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
URL: https://github.com/apache/hudi/pull/5423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5423:
URL: https://github.com/apache/hudi/pull/5423#issuecomment-1108526591
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a7fa04a277661c65b4f7faa48f0b69b39a7cee9a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7fa04a277661c65b4f7faa48f0b69b39a7cee9a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7fa04a277661c65b4f7faa48f0b69b39a7cee9a UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #5423:
URL: https://github.com/apache/hudi/pull/5423#discussion_r862264766
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -92,6 +92,7 @@
<include>org.apache.httpcomponents:fluent-hc</include>
<include>org.antlr:stringtemplate</include>
<include>org.apache.parquet:parquet-avro</include>
+ <include>org.apache.avro:avro</include>
Review Comment:
@xushiyan @alexeykudinkin could you guys check if adding avro dependency is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Baibaiwuguo commented on pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
Baibaiwuguo commented on PR #5423:
URL: https://github.com/apache/hudi/pull/5423#issuecomment-1120562323
@alexeykudinkin you are right, Our test spark colony delete avro. I'll add it and hudi run fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5423: [HUDI-3964] hudi-spark-bundle miss avro dependency
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5423:
URL: https://github.com/apache/hudi/pull/5423#discussion_r863137811
##########
packaging/hudi-spark-bundle/pom.xml:
##########
@@ -92,6 +92,7 @@
<include>org.apache.httpcomponents:fluent-hc</include>
<include>org.antlr:stringtemplate</include>
<include>org.apache.parquet:parquet-avro</include>
+ <include>org.apache.avro:avro</include>
Review Comment:
@Baibaiwuguo can you please explain why do you need an avro bundled into Hudi instead of relying on Spark provided one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org