[jira] [Work logged] (HIVE-25085) MetaStore Clients are being shared across different sessions

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25085?focusedWorklogId=592050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592050 ]

ASF GitHub Bot logged work on HIVE-25085:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/21 22:58
            Start Date: 02/May/21 22:58
    Worklog Time Spent: 10m 
      Work Description: scarlin-cloudera opened a new pull request #2238:
URL: https://github.com/apache/hive/pull/2238


   Testing this fix, please do not review yet.
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 592050)
    Remaining Estimate: 0h
            Time Spent: 10m

> MetaStore Clients are being shared across different sessions
> ------------------------------------------------------------
>
>                 Key: HIVE-25085
>                 URL: https://issues.apache.org/jira/browse/HIVE-25085
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2
>            Reporter: Steve Carlin
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Hive object (and the underlying MetaStoreClient object) seems to be getting shared across different sessions.  While most operations work, there can be occasional glitches.  
> One such noted glitch is that when session 1 ends, it closes the connection.  If session 2 then tries an operation, the first try will fail.  Normally this can proceed because the RetryingMetaStoreClient will re-establish a new connection, but in some operations, the retrying logic will not kick in (by design).
> It seems there was an attempt to fix this issue in HIVE-20682.  However, this implementation seems to be flawed.  The HiveSessionImpl object creates a Hive object and makes sure all thread queries belonging to the same session will run with the same Hive object.  The flaw is that the initial Hive Object within HiveSessionImpl is created in thread local storage.  The thread being run at that moment is not session specific.  It belongs to a thread pool that happens to be handling this specific session.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)