You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aaron Wood via Review Board <no...@reviews.apache.org> on 2017/05/22 17:24:23 UTC
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in
bytes.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/
-----------------------------------------------------------
(Updated May 22, 2017, 5:24 p.m.)
Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
Changes
-------
Fixed another test.
Summary (updated)
-----------------
Adjust tests to account for GCC 7.1 fix in bytes.hpp.
Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520
Repository: mesos
Description (updated)
-------
This fixes tests that uses the old inheritance types from `bytes.hpp`.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp ef0085316
src/tests/role_tests.cpp 03b6f7bd6
Diff: https://reviews.apache.org/r/59454/diff/2/
Changes: https://reviews.apache.org/r/59454/diff/1-2/
Testing
-------
`./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make check -j$(nproc)`
Thanks,
Aaron Wood
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in
bytes.hpp.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/#review176026
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On May 24, 2017, 5:53 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59454/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 5:53 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixes tests that uses the old inheritance types from `bytes.hpp`.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp ef0085316
> src/tests/role_tests.cpp 03b6f7bd6
>
>
> Diff: https://reviews.apache.org/r/59454/diff/3/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in
bytes.hpp.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/#review178163
-----------------------------------------------------------
Ship it!
lgtm, although I'll change the commit message -- there isn't anything specific about GCC 7.1 in this fix.
- Neil Conway
On May 24, 2017, 5:53 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59454/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 5:53 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixes tests that uses the old inheritance types from `bytes.hpp`.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp ef0085316
> src/tests/role_tests.cpp 03b6f7bd6
>
>
> Diff: https://reviews.apache.org/r/59454/diff/3/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in
bytes.hpp.
Posted by Aaron Wood via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/
-----------------------------------------------------------
(Updated May 24, 2017, 5:53 p.m.)
Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
Bugs: MESOS-7520
https://issues.apache.org/jira/browse/MESOS-7520
Repository: mesos
Description
-------
This fixes tests that uses the old inheritance types from `bytes.hpp`.
Diffs (updated)
-----
src/tests/persistent_volume_tests.cpp ef0085316
src/tests/role_tests.cpp 03b6f7bd6
Diff: https://reviews.apache.org/r/59454/diff/3/
Changes: https://reviews.apache.org/r/59454/diff/2-3/
Testing
-------
`./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make check -j$(nproc)`
Thanks,
Aaron Wood
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in
bytes.hpp.
Posted by Aaron Wood via Review Board <no...@reviews.apache.org>.
> On May 23, 2017, 10:50 p.m., James Peach wrote:
> > src/tests/role_tests.cpp
> > Line 909 (original), 909 (patched)
> > <https://reviews.apache.org/r/59454/diff/2/?file=1726951#file1726951line909>
> >
> > I think this should be:
> > ```
> > constexpr Bytes DISK_SIZE = Megabytes(1);
> > ```
Thanks for the catch.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/#review175875
-----------------------------------------------------------
On May 24, 2017, 5:53 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59454/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 5:53 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixes tests that uses the old inheritance types from `bytes.hpp`.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp ef0085316
> src/tests/role_tests.cpp 03b6f7bd6
>
>
> Diff: https://reviews.apache.org/r/59454/diff/3/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 59454: Adjust tests to account for GCC 7.1 fix in
bytes.hpp.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59454/#review175875
-----------------------------------------------------------
src/tests/role_tests.cpp
Line 909 (original), 909 (patched)
<https://reviews.apache.org/r/59454/#comment249207>
I think this should be:
```
constexpr Bytes DISK_SIZE = Megabytes(1);
```
- James Peach
On May 22, 2017, 5:24 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59454/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 5:24 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-7520
> https://issues.apache.org/jira/browse/MESOS-7520
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This fixes tests that uses the old inheritance types from `bytes.hpp`.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp ef0085316
> src/tests/role_tests.cpp 03b6f7bd6
>
>
> Diff: https://reviews.apache.org/r/59454/diff/2/
>
>
> Testing
> -------
>
> `./bootstrap && mkdir build && cd build && ../configure --disable-python --disable-java --disable-optimize --disable-hardening && make check -j$(nproc)`
>
>
> Thanks,
>
> Aaron Wood
>
>