You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2024/05/07 04:41:10 UTC
[PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
gnodet opened a new pull request, #14066:
URL: https://github.com/apache/camel/pull/14066
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make EndpointRegistry extends Map [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2109655641
org.apache.camel.issues.RecipientListUseOriginalMessageEndpointExceptionIssueTest.testRecipientListUseOriginalMessageIssue | 1.822s | FAILURE
-- | -- | --
org.apache.camel.builder.xml.XPathTest.testXPathSplitConcurrent | 1.763s | FAILURE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make EndpointRegistry extends Map [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2109485183
> > this PR needs to fix in the components as commented above
>
> In theory yes, in practice, no component is affected. The reason is that the `K` generic type in the `EnpointRegistry` is only used on `keySet()` and `entrySet()` methods, which are not used, and components, when they need to access the registry do so without using an intermediate variable which could cause a cast compilation error.
>
> I'm actually wondering if that parameter is needed at all, and while we're changing this method, it may be simpler to just make `EndpointRegistry` non parameterised and extends `Map<NormalizedEndpointUri, Endpoint>`. @davsclaus thoughts ?
Yes that is better as we dont need other kind of parameters at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make EndpointRegistry extends Map [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #14066:
URL: https://github.com/apache/camel/pull/14066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2097433246
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2100349470
this PR needs to fix in the components as commented above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2098118864
You likely need to update code at places like
camel-rest/src/main/java/org/apache/camel/component/rest/DefaultRestRegistry.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2097627282
You can add a note about this API change in the Camel 4.7 upgrade page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2097728160
Probably a good one to run full tests on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2109372777
> this PR needs to fix in the components as commented above
In theory yes, in practice, no component is affected. The reason is that the `K` generic type in the `EnpointRegistry` is only used on `keySet()` and `entrySet()` methods, which are not used, and components, when they need to access the registry do so without using an intermediate variable which could cause a cast compilation error.
I'm actually wondering if that parameter is needed at all, and while we're changing this method, it may be simpler to just make `EndpointRegistry` non parameterised and extends `Map<NormalizedEndpointUri, Endpoint>`. @davsclaus thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change EndpointRegistry to use NormalizedEndpointUri [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14066:
URL: https://github.com/apache/camel/pull/14066#issuecomment-2098120190
You can do a
cd components
git grep getEndpointRegistry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org