You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Richard Downer <ri...@apache.org> on 2015/06/23 13:07:31 UTC
0.7.0 release prep - unmerged PRs
I've been looking through the list of unmerged PRs, and with feedback from
Sam C, have pencilled in this list of PRs that should be merged before
making the release.
Reviewed and ready to merge
708 Ignore entity.addFeed(...) call with same feed object
707 BROOKLYN-137 stopIptables and openIptables don't work on CentOS7
706 Fix various integration tests
703 Jsgui tweaks
Reviewing not completed
705 Catalog default niceness
704 clean up how locations are rendered in the js gui, and expand "delete"
Reviewed with feedback; awaiting contributor to respond
694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
639 Allows for lists in templateOptions
Actions from here
Could I get a volunteer to review #705? It's a bit of a monster (54 changed
files with 1,533 additions and 409 deletions.)
And also #704 needs a complete review, but it's an easier size to manage.
Andrea, #694 is waiting on your response to review comments. Could you take
a look please?
Nakomis is unable to look at #639 today, but it'd be a really useful one to
get into the release. I'm going to take over this one. I'll then need
somebody else to review it.
Finally I'll get the ready-to-merge PRs merged. Once that's done we'll take
a look at the state of the integration tests.
Thanks,
Richard.
Re: 0.7.0 release prep - unmerged PRs
Posted by Richard Downer <ri...@apache.org>.
Our last remaining PRs are:
#717 - open port range in security group
#715 - release notes
#715 is blocked on a conclusion of the #687 discussion (for which I've
started another thread)
#717 was blocked on test failures, but I see they have now been resolved,
so that is no longer a blocker :-)
Richard.
On Thu, 25 Jun 2015 at 12:27 Martin Harris <ma...@cloudsoftcorp.com>
wrote:
> I may be a little late to the party, but I've just found (and fixed) a
> fairly fundamental issue here:
> https://github.com/apache/incubator-brooklyn/pull/717
>
> Is there still time to get this in to the release?
>
> Cheers
>
> M
>
> On 24 June 2015 at 20:07, Mike Zaccardo <mi...@cloudsoftcorp.com>
> wrote:
>
> > I've reviewed that list -- all LGTM with only minor comments.
> >
> > On Wed, Jun 24, 2015 at 3:25 AM, Richard Downer <ri...@apache.org>
> > wrote:
> >
> > > Thanks everyone. We've got through most of the items from yesterday; a
> > > couple of rework tasks now need re-reviewed, and there's been a few new
> > PRs
> > > that fix test failures which would be beneficial to include, so need
> > > reviewed too.
> > >
> > > Could I get volunteers to review and merge:
> > > 714 Clarify operation of `templateOptions` config key
> > > 713 Fixing Integration test - RubyRepIntegrationTest
> > > 712 Fixing Integration tests for 0.7.0
> > > 710 Remove obsolete Tomcat fail binding test
> > > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> > >
> > > Sam, please could you submit a PR which updates docs/guide/misc/
> > > release-notes.md, as you discussed on IRC?
> > >
> > > Thanks all,
> > >
> > > Richard.
> > >
> > >
> > >
> > > On Tue, 23 Jun 2015 at 14:39 Duncan Grant <
> > duncan.grant@cloudsoftcorp.com>
> > > wrote:
> > >
> > > > Richard, Svet, Sam,
> > > >
> > > > I've created a PR
> > https://github.com/apache/incubator-brooklyn/pull/711
> > > to
> > > > add some documentation for the AWS VPC issue described in #705. I'm
> > not
> > > > sure whether this is a good place for it but I couldn't see a better
> > one.
> > > >
> > > > Svet,
> > > > Could you review to make sure that my understanding is something like
> > > > reality.
> > > >
> > > > Sam
> > > > I'll write some release notes that detail this as a known issue and,
> if
> > > > merged, point to this bit of documentation.
> > > >
> > > > Regards
> > > >
> > > > Duncan
> > > >
> > > > On Tue, 23 Jun 2015 at 12:10 Svetoslav Neykov <
> > > > svetoslav.neykov@cloudsoftcorp.com> wrote:
> > > >
> > > > > I'll go though #705.
> > > > >
> > > > > Svet.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > > On 23.06.2015 г., at 14:07, Richard Downer <ri...@apache.org>
> > > wrote:
> > > > > >
> > > > > > I've been looking through the list of unmerged PRs, and with
> > feedback
> > > > > from
> > > > > > Sam C, have pencilled in this list of PRs that should be merged
> > > before
> > > > > > making the release.
> > > > > >
> > > > > > Reviewed and ready to merge
> > > > > > 708 Ignore entity.addFeed(...) call with same feed object
> > > > > > 707 BROOKLYN-137 stopIptables and openIptables don't work on
> > CentOS7
> > > > > > 706 Fix various integration tests
> > > > > > 703 Jsgui tweaks
> > > > > >
> > > > > > Reviewing not completed
> > > > > > 705 Catalog default niceness
> > > > > > 704 clean up how locations are rendered in the js gui, and expand
> > > > > "delete"
> > > > > >
> > > > > > Reviewed with feedback; awaiting contributor to respond
> > > > > > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> > > > > > 639 Allows for lists in templateOptions
> > > > > >
> > > > > > Actions from here
> > > > > >
> > > > > > Could I get a volunteer to review #705? It's a bit of a monster
> (54
> > > > > changed
> > > > > > files with 1,533 additions and 409 deletions.)
> > > > > >
> > > > > > And also #704 needs a complete review, but it's an easier size to
> > > > manage.
> > > > > >
> > > > > > Andrea, #694 is waiting on your response to review comments.
> Could
> > > you
> > > > > take
> > > > > > a look please?
> > > > > >
> > > > > > Nakomis is unable to look at #639 today, but it'd be a really
> > useful
> > > > one
> > > > > to
> > > > > > get into the release. I'm going to take over this one. I'll then
> > need
> > > > > > somebody else to review it.
> > > > > >
> > > > > > Finally I'll get the ready-to-merge PRs merged. Once that's done
> > > we'll
> > > > > take
> > > > > > a look at the state of the integration tests.
> > > > > >
> > > > > > Thanks,
> > > > > > Richard.
> > > > >
> > > > >
> > > > > --
> > > > > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > > > > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> > > > >
> > > > > This e-mail message is confidential and for use by the addressee
> > only.
> > > If
> > > > > the message is received by anyone other than the addressee, please
> > > return
> > > > > the message to the sender by replying to it and then delete the
> > message
> > > > > from your computer. Internet e-mails are not necessarily secure.
> > > > Cloudsoft
> > > > > Corporation Limited does not accept responsibility for changes made
> > to
> > > > this
> > > > > message after it was sent.
> > > > >
> > > > > Whilst all reasonable care has been taken to avoid the transmission
> > of
> > > > > viruses, it is the responsibility of the recipient to ensure that
> the
> > > > > onward transmission, opening or use of this message and any
> > attachments
> > > > > will not adversely affect its systems or data. No responsibility is
> > > > > accepted by Cloudsoft Corporation Limited in this regard and the
> > > > recipient
> > > > > should carry out such virus and other checks as it considers
> > > appropriate.
> > > > >
> > > >
> > > > --
> > > > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > > > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> > > >
> > > > This e-mail message is confidential and for use by the addressee
> only.
> > If
> > > > the message is received by anyone other than the addressee, please
> > return
> > > > the message to the sender by replying to it and then delete the
> message
> > > > from your computer. Internet e-mails are not necessarily secure.
> > > Cloudsoft
> > > > Corporation Limited does not accept responsibility for changes made
> to
> > > this
> > > > message after it was sent.
> > > >
> > > > Whilst all reasonable care has been taken to avoid the transmission
> of
> > > > viruses, it is the responsibility of the recipient to ensure that the
> > > > onward transmission, opening or use of this message and any
> attachments
> > > > will not adversely affect its systems or data. No responsibility is
> > > > accepted by Cloudsoft Corporation Limited in this regard and the
> > > recipient
> > > > should carry out such virus and other checks as it considers
> > appropriate.
> > > >
> > >
> >
> > --
> > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> >
> > This e-mail message is confidential and for use by the addressee only. If
> > the message is received by anyone other than the addressee, please return
> > the message to the sender by replying to it and then delete the message
> > from your computer. Internet e-mails are not necessarily secure.
> Cloudsoft
> > Corporation Limited does not accept responsibility for changes made to
> this
> > message after it was sent.
> >
> > Whilst all reasonable care has been taken to avoid the transmission of
> > viruses, it is the responsibility of the recipient to ensure that the
> > onward transmission, opening or use of this message and any attachments
> > will not adversely affect its systems or data. No responsibility is
> > accepted by Cloudsoft Corporation Limited in this regard and the
> recipient
> > should carry out such virus and other checks as it considers appropriate.
> >
>
>
>
> --
> Martin Harris
> Lead Software Engineer
> Cloudsoft Corporation Ltd
> www.cloudsoftcorp.com
> Mobile: +44 (0)7989 047-855
>
> --
> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>
> This e-mail message is confidential and for use by the addressee only. If
> the message is received by anyone other than the addressee, please return
> the message to the sender by replying to it and then delete the message
> from your computer. Internet e-mails are not necessarily secure. Cloudsoft
> Corporation Limited does not accept responsibility for changes made to this
> message after it was sent.
>
> Whilst all reasonable care has been taken to avoid the transmission of
> viruses, it is the responsibility of the recipient to ensure that the
> onward transmission, opening or use of this message and any attachments
> will not adversely affect its systems or data. No responsibility is
> accepted by Cloudsoft Corporation Limited in this regard and the recipient
> should carry out such virus and other checks as it considers appropriate.
>
Re: 0.7.0 release prep - unmerged PRs
Posted by Martin Harris <ma...@cloudsoftcorp.com>.
I may be a little late to the party, but I've just found (and fixed) a
fairly fundamental issue here:
https://github.com/apache/incubator-brooklyn/pull/717
Is there still time to get this in to the release?
Cheers
M
On 24 June 2015 at 20:07, Mike Zaccardo <mi...@cloudsoftcorp.com>
wrote:
> I've reviewed that list -- all LGTM with only minor comments.
>
> On Wed, Jun 24, 2015 at 3:25 AM, Richard Downer <ri...@apache.org>
> wrote:
>
> > Thanks everyone. We've got through most of the items from yesterday; a
> > couple of rework tasks now need re-reviewed, and there's been a few new
> PRs
> > that fix test failures which would be beneficial to include, so need
> > reviewed too.
> >
> > Could I get volunteers to review and merge:
> > 714 Clarify operation of `templateOptions` config key
> > 713 Fixing Integration test - RubyRepIntegrationTest
> > 712 Fixing Integration tests for 0.7.0
> > 710 Remove obsolete Tomcat fail binding test
> > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> >
> > Sam, please could you submit a PR which updates docs/guide/misc/
> > release-notes.md, as you discussed on IRC?
> >
> > Thanks all,
> >
> > Richard.
> >
> >
> >
> > On Tue, 23 Jun 2015 at 14:39 Duncan Grant <
> duncan.grant@cloudsoftcorp.com>
> > wrote:
> >
> > > Richard, Svet, Sam,
> > >
> > > I've created a PR
> https://github.com/apache/incubator-brooklyn/pull/711
> > to
> > > add some documentation for the AWS VPC issue described in #705. I'm
> not
> > > sure whether this is a good place for it but I couldn't see a better
> one.
> > >
> > > Svet,
> > > Could you review to make sure that my understanding is something like
> > > reality.
> > >
> > > Sam
> > > I'll write some release notes that detail this as a known issue and, if
> > > merged, point to this bit of documentation.
> > >
> > > Regards
> > >
> > > Duncan
> > >
> > > On Tue, 23 Jun 2015 at 12:10 Svetoslav Neykov <
> > > svetoslav.neykov@cloudsoftcorp.com> wrote:
> > >
> > > > I'll go though #705.
> > > >
> > > > Svet.
> > > >
> > > >
> > > >
> > > >
> > > > > On 23.06.2015 г., at 14:07, Richard Downer <ri...@apache.org>
> > wrote:
> > > > >
> > > > > I've been looking through the list of unmerged PRs, and with
> feedback
> > > > from
> > > > > Sam C, have pencilled in this list of PRs that should be merged
> > before
> > > > > making the release.
> > > > >
> > > > > Reviewed and ready to merge
> > > > > 708 Ignore entity.addFeed(...) call with same feed object
> > > > > 707 BROOKLYN-137 stopIptables and openIptables don't work on
> CentOS7
> > > > > 706 Fix various integration tests
> > > > > 703 Jsgui tweaks
> > > > >
> > > > > Reviewing not completed
> > > > > 705 Catalog default niceness
> > > > > 704 clean up how locations are rendered in the js gui, and expand
> > > > "delete"
> > > > >
> > > > > Reviewed with feedback; awaiting contributor to respond
> > > > > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> > > > > 639 Allows for lists in templateOptions
> > > > >
> > > > > Actions from here
> > > > >
> > > > > Could I get a volunteer to review #705? It's a bit of a monster (54
> > > > changed
> > > > > files with 1,533 additions and 409 deletions.)
> > > > >
> > > > > And also #704 needs a complete review, but it's an easier size to
> > > manage.
> > > > >
> > > > > Andrea, #694 is waiting on your response to review comments. Could
> > you
> > > > take
> > > > > a look please?
> > > > >
> > > > > Nakomis is unable to look at #639 today, but it'd be a really
> useful
> > > one
> > > > to
> > > > > get into the release. I'm going to take over this one. I'll then
> need
> > > > > somebody else to review it.
> > > > >
> > > > > Finally I'll get the ready-to-merge PRs merged. Once that's done
> > we'll
> > > > take
> > > > > a look at the state of the integration tests.
> > > > >
> > > > > Thanks,
> > > > > Richard.
> > > >
> > > >
> > > > --
> > > > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > > > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> > > >
> > > > This e-mail message is confidential and for use by the addressee
> only.
> > If
> > > > the message is received by anyone other than the addressee, please
> > return
> > > > the message to the sender by replying to it and then delete the
> message
> > > > from your computer. Internet e-mails are not necessarily secure.
> > > Cloudsoft
> > > > Corporation Limited does not accept responsibility for changes made
> to
> > > this
> > > > message after it was sent.
> > > >
> > > > Whilst all reasonable care has been taken to avoid the transmission
> of
> > > > viruses, it is the responsibility of the recipient to ensure that the
> > > > onward transmission, opening or use of this message and any
> attachments
> > > > will not adversely affect its systems or data. No responsibility is
> > > > accepted by Cloudsoft Corporation Limited in this regard and the
> > > recipient
> > > > should carry out such virus and other checks as it considers
> > appropriate.
> > > >
> > >
> > > --
> > > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> > >
> > > This e-mail message is confidential and for use by the addressee only.
> If
> > > the message is received by anyone other than the addressee, please
> return
> > > the message to the sender by replying to it and then delete the message
> > > from your computer. Internet e-mails are not necessarily secure.
> > Cloudsoft
> > > Corporation Limited does not accept responsibility for changes made to
> > this
> > > message after it was sent.
> > >
> > > Whilst all reasonable care has been taken to avoid the transmission of
> > > viruses, it is the responsibility of the recipient to ensure that the
> > > onward transmission, opening or use of this message and any attachments
> > > will not adversely affect its systems or data. No responsibility is
> > > accepted by Cloudsoft Corporation Limited in this regard and the
> > recipient
> > > should carry out such virus and other checks as it considers
> appropriate.
> > >
> >
>
> --
> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>
> This e-mail message is confidential and for use by the addressee only. If
> the message is received by anyone other than the addressee, please return
> the message to the sender by replying to it and then delete the message
> from your computer. Internet e-mails are not necessarily secure. Cloudsoft
> Corporation Limited does not accept responsibility for changes made to this
> message after it was sent.
>
> Whilst all reasonable care has been taken to avoid the transmission of
> viruses, it is the responsibility of the recipient to ensure that the
> onward transmission, opening or use of this message and any attachments
> will not adversely affect its systems or data. No responsibility is
> accepted by Cloudsoft Corporation Limited in this regard and the recipient
> should carry out such virus and other checks as it considers appropriate.
>
--
Martin Harris
Lead Software Engineer
Cloudsoft Corporation Ltd
www.cloudsoftcorp.com
Mobile: +44 (0)7989 047-855
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.
Re: 0.7.0 release prep - unmerged PRs
Posted by Mike Zaccardo <mi...@cloudsoftcorp.com>.
I've reviewed that list -- all LGTM with only minor comments.
On Wed, Jun 24, 2015 at 3:25 AM, Richard Downer <ri...@apache.org> wrote:
> Thanks everyone. We've got through most of the items from yesterday; a
> couple of rework tasks now need re-reviewed, and there's been a few new PRs
> that fix test failures which would be beneficial to include, so need
> reviewed too.
>
> Could I get volunteers to review and merge:
> 714 Clarify operation of `templateOptions` config key
> 713 Fixing Integration test - RubyRepIntegrationTest
> 712 Fixing Integration tests for 0.7.0
> 710 Remove obsolete Tomcat fail binding test
> 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
>
> Sam, please could you submit a PR which updates docs/guide/misc/
> release-notes.md, as you discussed on IRC?
>
> Thanks all,
>
> Richard.
>
>
>
> On Tue, 23 Jun 2015 at 14:39 Duncan Grant <du...@cloudsoftcorp.com>
> wrote:
>
> > Richard, Svet, Sam,
> >
> > I've created a PR https://github.com/apache/incubator-brooklyn/pull/711
> to
> > add some documentation for the AWS VPC issue described in #705. I'm not
> > sure whether this is a good place for it but I couldn't see a better one.
> >
> > Svet,
> > Could you review to make sure that my understanding is something like
> > reality.
> >
> > Sam
> > I'll write some release notes that detail this as a known issue and, if
> > merged, point to this bit of documentation.
> >
> > Regards
> >
> > Duncan
> >
> > On Tue, 23 Jun 2015 at 12:10 Svetoslav Neykov <
> > svetoslav.neykov@cloudsoftcorp.com> wrote:
> >
> > > I'll go though #705.
> > >
> > > Svet.
> > >
> > >
> > >
> > >
> > > > On 23.06.2015 г., at 14:07, Richard Downer <ri...@apache.org>
> wrote:
> > > >
> > > > I've been looking through the list of unmerged PRs, and with feedback
> > > from
> > > > Sam C, have pencilled in this list of PRs that should be merged
> before
> > > > making the release.
> > > >
> > > > Reviewed and ready to merge
> > > > 708 Ignore entity.addFeed(...) call with same feed object
> > > > 707 BROOKLYN-137 stopIptables and openIptables don't work on CentOS7
> > > > 706 Fix various integration tests
> > > > 703 Jsgui tweaks
> > > >
> > > > Reviewing not completed
> > > > 705 Catalog default niceness
> > > > 704 clean up how locations are rendered in the js gui, and expand
> > > "delete"
> > > >
> > > > Reviewed with feedback; awaiting contributor to respond
> > > > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> > > > 639 Allows for lists in templateOptions
> > > >
> > > > Actions from here
> > > >
> > > > Could I get a volunteer to review #705? It's a bit of a monster (54
> > > changed
> > > > files with 1,533 additions and 409 deletions.)
> > > >
> > > > And also #704 needs a complete review, but it's an easier size to
> > manage.
> > > >
> > > > Andrea, #694 is waiting on your response to review comments. Could
> you
> > > take
> > > > a look please?
> > > >
> > > > Nakomis is unable to look at #639 today, but it'd be a really useful
> > one
> > > to
> > > > get into the release. I'm going to take over this one. I'll then need
> > > > somebody else to review it.
> > > >
> > > > Finally I'll get the ready-to-merge PRs merged. Once that's done
> we'll
> > > take
> > > > a look at the state of the integration tests.
> > > >
> > > > Thanks,
> > > > Richard.
> > >
> > >
> > > --
> > > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> > >
> > > This e-mail message is confidential and for use by the addressee only.
> If
> > > the message is received by anyone other than the addressee, please
> return
> > > the message to the sender by replying to it and then delete the message
> > > from your computer. Internet e-mails are not necessarily secure.
> > Cloudsoft
> > > Corporation Limited does not accept responsibility for changes made to
> > this
> > > message after it was sent.
> > >
> > > Whilst all reasonable care has been taken to avoid the transmission of
> > > viruses, it is the responsibility of the recipient to ensure that the
> > > onward transmission, opening or use of this message and any attachments
> > > will not adversely affect its systems or data. No responsibility is
> > > accepted by Cloudsoft Corporation Limited in this regard and the
> > recipient
> > > should carry out such virus and other checks as it considers
> appropriate.
> > >
> >
> > --
> > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> >
> > This e-mail message is confidential and for use by the addressee only. If
> > the message is received by anyone other than the addressee, please return
> > the message to the sender by replying to it and then delete the message
> > from your computer. Internet e-mails are not necessarily secure.
> Cloudsoft
> > Corporation Limited does not accept responsibility for changes made to
> this
> > message after it was sent.
> >
> > Whilst all reasonable care has been taken to avoid the transmission of
> > viruses, it is the responsibility of the recipient to ensure that the
> > onward transmission, opening or use of this message and any attachments
> > will not adversely affect its systems or data. No responsibility is
> > accepted by Cloudsoft Corporation Limited in this regard and the
> recipient
> > should carry out such virus and other checks as it considers appropriate.
> >
>
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.
Re: 0.7.0 release prep - unmerged PRs
Posted by Richard Downer <ri...@apache.org>.
Thanks everyone. We've got through most of the items from yesterday; a
couple of rework tasks now need re-reviewed, and there's been a few new PRs
that fix test failures which would be beneficial to include, so need
reviewed too.
Could I get volunteers to review and merge:
714 Clarify operation of `templateOptions` config key
713 Fixing Integration test - RubyRepIntegrationTest
712 Fixing Integration tests for 0.7.0
710 Remove obsolete Tomcat fail binding test
694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
Sam, please could you submit a PR which updates docs/guide/misc/
release-notes.md, as you discussed on IRC?
Thanks all,
Richard.
On Tue, 23 Jun 2015 at 14:39 Duncan Grant <du...@cloudsoftcorp.com>
wrote:
> Richard, Svet, Sam,
>
> I've created a PR https://github.com/apache/incubator-brooklyn/pull/711 to
> add some documentation for the AWS VPC issue described in #705. I'm not
> sure whether this is a good place for it but I couldn't see a better one.
>
> Svet,
> Could you review to make sure that my understanding is something like
> reality.
>
> Sam
> I'll write some release notes that detail this as a known issue and, if
> merged, point to this bit of documentation.
>
> Regards
>
> Duncan
>
> On Tue, 23 Jun 2015 at 12:10 Svetoslav Neykov <
> svetoslav.neykov@cloudsoftcorp.com> wrote:
>
> > I'll go though #705.
> >
> > Svet.
> >
> >
> >
> >
> > > On 23.06.2015 г., at 14:07, Richard Downer <ri...@apache.org> wrote:
> > >
> > > I've been looking through the list of unmerged PRs, and with feedback
> > from
> > > Sam C, have pencilled in this list of PRs that should be merged before
> > > making the release.
> > >
> > > Reviewed and ready to merge
> > > 708 Ignore entity.addFeed(...) call with same feed object
> > > 707 BROOKLYN-137 stopIptables and openIptables don't work on CentOS7
> > > 706 Fix various integration tests
> > > 703 Jsgui tweaks
> > >
> > > Reviewing not completed
> > > 705 Catalog default niceness
> > > 704 clean up how locations are rendered in the js gui, and expand
> > "delete"
> > >
> > > Reviewed with feedback; awaiting contributor to respond
> > > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> > > 639 Allows for lists in templateOptions
> > >
> > > Actions from here
> > >
> > > Could I get a volunteer to review #705? It's a bit of a monster (54
> > changed
> > > files with 1,533 additions and 409 deletions.)
> > >
> > > And also #704 needs a complete review, but it's an easier size to
> manage.
> > >
> > > Andrea, #694 is waiting on your response to review comments. Could you
> > take
> > > a look please?
> > >
> > > Nakomis is unable to look at #639 today, but it'd be a really useful
> one
> > to
> > > get into the release. I'm going to take over this one. I'll then need
> > > somebody else to review it.
> > >
> > > Finally I'll get the ready-to-merge PRs merged. Once that's done we'll
> > take
> > > a look at the state of the integration tests.
> > >
> > > Thanks,
> > > Richard.
> >
> >
> > --
> > Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> > Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
> >
> > This e-mail message is confidential and for use by the addressee only. If
> > the message is received by anyone other than the addressee, please return
> > the message to the sender by replying to it and then delete the message
> > from your computer. Internet e-mails are not necessarily secure.
> Cloudsoft
> > Corporation Limited does not accept responsibility for changes made to
> this
> > message after it was sent.
> >
> > Whilst all reasonable care has been taken to avoid the transmission of
> > viruses, it is the responsibility of the recipient to ensure that the
> > onward transmission, opening or use of this message and any attachments
> > will not adversely affect its systems or data. No responsibility is
> > accepted by Cloudsoft Corporation Limited in this regard and the
> recipient
> > should carry out such virus and other checks as it considers appropriate.
> >
>
> --
> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>
> This e-mail message is confidential and for use by the addressee only. If
> the message is received by anyone other than the addressee, please return
> the message to the sender by replying to it and then delete the message
> from your computer. Internet e-mails are not necessarily secure. Cloudsoft
> Corporation Limited does not accept responsibility for changes made to this
> message after it was sent.
>
> Whilst all reasonable care has been taken to avoid the transmission of
> viruses, it is the responsibility of the recipient to ensure that the
> onward transmission, opening or use of this message and any attachments
> will not adversely affect its systems or data. No responsibility is
> accepted by Cloudsoft Corporation Limited in this regard and the recipient
> should carry out such virus and other checks as it considers appropriate.
>
Re: 0.7.0 release prep - unmerged PRs
Posted by Duncan Grant <du...@cloudsoftcorp.com>.
Richard, Svet, Sam,
I've created a PR https://github.com/apache/incubator-brooklyn/pull/711 to
add some documentation for the AWS VPC issue described in #705. I'm not
sure whether this is a good place for it but I couldn't see a better one.
Svet,
Could you review to make sure that my understanding is something like
reality.
Sam
I'll write some release notes that detail this as a known issue and, if
merged, point to this bit of documentation.
Regards
Duncan
On Tue, 23 Jun 2015 at 12:10 Svetoslav Neykov <
svetoslav.neykov@cloudsoftcorp.com> wrote:
> I'll go though #705.
>
> Svet.
>
>
>
>
> > On 23.06.2015 г., at 14:07, Richard Downer <ri...@apache.org> wrote:
> >
> > I've been looking through the list of unmerged PRs, and with feedback
> from
> > Sam C, have pencilled in this list of PRs that should be merged before
> > making the release.
> >
> > Reviewed and ready to merge
> > 708 Ignore entity.addFeed(...) call with same feed object
> > 707 BROOKLYN-137 stopIptables and openIptables don't work on CentOS7
> > 706 Fix various integration tests
> > 703 Jsgui tweaks
> >
> > Reviewing not completed
> > 705 Catalog default niceness
> > 704 clean up how locations are rendered in the js gui, and expand
> "delete"
> >
> > Reviewed with feedback; awaiting contributor to respond
> > 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> > 639 Allows for lists in templateOptions
> >
> > Actions from here
> >
> > Could I get a volunteer to review #705? It's a bit of a monster (54
> changed
> > files with 1,533 additions and 409 deletions.)
> >
> > And also #704 needs a complete review, but it's an easier size to manage.
> >
> > Andrea, #694 is waiting on your response to review comments. Could you
> take
> > a look please?
> >
> > Nakomis is unable to look at #639 today, but it'd be a really useful one
> to
> > get into the release. I'm going to take over this one. I'll then need
> > somebody else to review it.
> >
> > Finally I'll get the ready-to-merge PRs merged. Once that's done we'll
> take
> > a look at the state of the integration tests.
> >
> > Thanks,
> > Richard.
>
>
> --
> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
> Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>
> This e-mail message is confidential and for use by the addressee only. If
> the message is received by anyone other than the addressee, please return
> the message to the sender by replying to it and then delete the message
> from your computer. Internet e-mails are not necessarily secure. Cloudsoft
> Corporation Limited does not accept responsibility for changes made to this
> message after it was sent.
>
> Whilst all reasonable care has been taken to avoid the transmission of
> viruses, it is the responsibility of the recipient to ensure that the
> onward transmission, opening or use of this message and any attachments
> will not adversely affect its systems or data. No responsibility is
> accepted by Cloudsoft Corporation Limited in this regard and the recipient
> should carry out such virus and other checks as it considers appropriate.
>
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.
Re: 0.7.0 release prep - unmerged PRs
Posted by Svetoslav Neykov <sv...@cloudsoftcorp.com>.
I'll go though #705.
Svet.
> On 23.06.2015 г., at 14:07, Richard Downer <ri...@apache.org> wrote:
>
> I've been looking through the list of unmerged PRs, and with feedback from
> Sam C, have pencilled in this list of PRs that should be merged before
> making the release.
>
> Reviewed and ready to merge
> 708 Ignore entity.addFeed(...) call with same feed object
> 707 BROOKLYN-137 stopIptables and openIptables don't work on CentOS7
> 706 Fix various integration tests
> 703 Jsgui tweaks
>
> Reviewing not completed
> 705 Catalog default niceness
> 704 clean up how locations are rendered in the js gui, and expand "delete"
>
> Reviewed with feedback; awaiting contributor to respond
> 694 [BROOKLYN-99] add support for NovaSecurityGroupExtension
> 639 Allows for lists in templateOptions
>
> Actions from here
>
> Could I get a volunteer to review #705? It's a bit of a monster (54 changed
> files with 1,533 additions and 409 deletions.)
>
> And also #704 needs a complete review, but it's an easier size to manage.
>
> Andrea, #694 is waiting on your response to review comments. Could you take
> a look please?
>
> Nakomis is unable to look at #639 today, but it'd be a really useful one to
> get into the release. I'm going to take over this one. I'll then need
> somebody else to review it.
>
> Finally I'll get the ready-to-merge PRs merged. Once that's done we'll take
> a look at the state of the integration tests.
>
> Thanks,
> Richard.
--
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
This e-mail message is confidential and for use by the addressee only. If
the message is received by anyone other than the addressee, please return
the message to the sender by replying to it and then delete the message
from your computer. Internet e-mails are not necessarily secure. Cloudsoft
Corporation Limited does not accept responsibility for changes made to this
message after it was sent.
Whilst all reasonable care has been taken to avoid the transmission of
viruses, it is the responsibility of the recipient to ensure that the
onward transmission, opening or use of this message and any attachments
will not adversely affect its systems or data. No responsibility is
accepted by Cloudsoft Corporation Limited in this regard and the recipient
should carry out such virus and other checks as it considers appropriate.