You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by de...@apache.org on 2017/09/17 12:29:35 UTC

[myfaces-trinidad] 07/07: TRINIDAD-2140

This is an automated email from the ASF dual-hosted git repository.

deki pushed a commit to branch jwaldman-offline-mode-branch
in repository https://gitbox.apache.org/repos/asf/myfaces-trinidad.git

commit eea09ecd5e545be84cbcb90ce9d956ea5c4c4df6
Author: Matthew Cooper <mc...@apache.org>
AuthorDate: Fri Oct 28 20:18:06 2011 +0000

    TRINIDAD-2140
    
    Thanks to Pavitra for the patch.
---
 .../java/org/apache/myfaces/trinidad/context/RequestContext.java | 2 +-
 .../myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java   | 9 +++++----
 .../trinidadinternal/renderkit/core/CoreRenderingContext.java    | 8 ++++----
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java b/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java
index f538c42..a510420 100644
--- a/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java
+++ b/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/RequestContext.java
@@ -333,7 +333,7 @@ abstract public class RequestContext
   public enum OutputMode
   {
     DEFAULT("default"), PORTLET("portlet"), PRINTABLE("printable"), EMAIL("email"),
-    OFFLINE("offline"), WEB_CRAWLER("webcrawler");
+    ATTACHMENT("attachment"), WEB_CRAWLER("webcrawler");
     
     private OutputMode(String id)
     {
diff --git a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java
index 0b756cd..2ade6b5 100644
--- a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java
+++ b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderKit.java
@@ -112,10 +112,11 @@ public class CoreRenderKit extends RenderKitDecorator
   static public final String OUTPUT_MODE_EMAIL = "email";
 
   /**
-   * An offline browser output mode.  Render the content such that the output can be taken
-   * offline.  Interactions requiring server communication should be avoided.
+   * An attachment browser output mode. Render the content such that the output can be sent as an 
+   * email attachment that can be viewed offline. Interactions requiring server communication 
+   * should be completely avoided.
    */
-  static public final String OUTPUT_MODE_OFFLINE = "offline";
+  static public final String OUTPUT_MODE_ATTACHMENT = "attachment";
 
   /**
    * Web Creawler output mode.  Render the content for consumption by a web crawler
@@ -123,7 +124,7 @@ public class CoreRenderKit extends RenderKitDecorator
   static public final String OUTPUT_MODE_WEB_CRAWLER = "webcrawler";
 
 
-  public enum OutputMode {normal, portlet, printable, email, offline}
+  public enum OutputMode {normal, portlet, printable, email, attachment}
 
   static public final String RETURN_PARAM = "rtrn";
 
diff --git a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
index ae08920..c83e3c0 100644
--- a/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
+++ b/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java
@@ -671,9 +671,9 @@ public class CoreRenderingContext extends RenderingContext
         return AgentUtil.mergeCapabilities(agent, _PORTLET_CAPABILITIES);
       }
     }
-    else if (CoreRenderKit.OUTPUT_MODE_OFFLINE.equals(outputMode))
+    else if (CoreRenderKit.OUTPUT_MODE_ATTACHMENT.equals(outputMode))
     {
-      return AgentUtil.mergeCapabilities(agent, _OFFLINE_CAPABILITIES);
+      return AgentUtil.mergeCapabilities(agent, _ATTACHMENT_CAPABILITIES);
     }
     else if (CoreRenderKit.OUTPUT_MODE_WEB_CRAWLER.equals(outputMode))
     {
@@ -827,7 +827,7 @@ public class CoreRenderingContext extends RenderingContext
   static private final Map<Object, Object> _ENHANCED_PORTLET_CAPABILITIES =
     new HashMap<Object, Object>();
 
-  static private final Map<Object, Object> _OFFLINE_CAPABILITIES =
+  static private final Map<Object, Object> _ATTACHMENT_CAPABILITIES =
     new HashMap<Object, Object>();
 
   static private final Map<Object, Object> _WEB_CRAWLER_CAPABILITIES =
@@ -885,7 +885,7 @@ public class CoreRenderingContext extends RenderingContext
                               Boolean.FALSE);
 
     // turn off PPR
-    _OFFLINE_CAPABILITIES.put(TrinidadAgent.CAP_PARTIAL_RENDERING, Boolean.FALSE);
+    _ATTACHMENT_CAPABILITIES.put(TrinidadAgent.CAP_PARTIAL_RENDERING, Boolean.FALSE);
   }
 
   static private final TrinidadLogger _LOG =

-- 
To stop receiving notification emails like this one, please contact
"commits@myfaces.apache.org" <co...@myfaces.apache.org>.