You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/01/12 02:23:20 UTC

[GitHub] spark pull request #20183: [SPARK-22986][Core] Use a cache to avoid instanti...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20183#discussion_r161127616
  
    --- Diff: core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala ---
    @@ -52,6 +54,10 @@ private[spark] class BroadcastManager(
     
       private val nextBroadcastId = new AtomicLong(0)
     
    +  private[broadcast] val cachedValues = {
    +    new ReferenceMap(AbstractReferenceMap.HARD, AbstractReferenceMap.WEAK)
    --- End diff --
    
    why is the key not a weak reference?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org