You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by ledor473 <gi...@git.apache.org> on 2016/01/21 22:08:45 UTC
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
GitHub user ledor473 opened a pull request:
https://github.com/apache/nifi/pull/183
NIFI-1423 Allow to penalize FlowFiles to No Retry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ledor473/nifi penalize-http-no-retry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #183
----
commit 8f0d5419477706433df6200ea97c7e588fd422a7
Author: Louis-Etienne Dorval <lo...@ticketmaster.com>
Date: 2016-01-21T21:08:07Z
NIFI-1423 Allow to penalize FlowFiles that are routed to No Retry relationship
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176597280
Agree with @JPercivall regarding the rollback to be able to get a full handle on rolled back files for a given session/execution to understand how the processor behaved. Scanning through the codebase, these are a minority of usages and typically would only get invoked when there is a dev issue causing exceptions, but could see it getting more usage within AbstractionSessionFactory based processors where that functionality could be preferred. Seems like a quick effort for consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176546233
Did a maven contrib check build and verified the functionality using a test http server. Once the comments are addressed I can merge in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by ledor473 <gi...@git.apache.org>.
Github user ledor473 commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176961200
All very valid points there, I'll have a look at them.
The merge request will be updated with the fixes soon and will also be up-to-date with the current master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176540108
When MockProcessSession.rollback(boolean)[1] is called it is, the boolean is telling the session whether or not the flowfiles should be penalized. In the event the boolean is true if the session shouldn't it clear the penalized list then add all the flowfiles to the list?
[1] https://github.com/apache/nifi/blob/fd35b8ffd7d4a66ef149c1bd1341dfee3ede80c7/nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java#L522-L522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-175748677
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176544259
I know this isn't part of the ticket but, there are numerous lines in the unit tests that say " // getMyFlowFiles();". I believe they're relicts from before the refactor. Could you remove them in this commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by ledor473 <gi...@git.apache.org>.
Github user ledor473 commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-181426043
I've pushed the new version that includes all the fixes for the comments above.
Contrib check done and up-to-date to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1423 Allow to penalize FlowFiles to No Ret...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/183#issuecomment-176533014
I believe flowfiles should be removed from the penalized list when MockProcessSession.remove() is called: https://github.com/apache/nifi/blob/fd35b8ffd7d4a66ef149c1bd1341dfee3ede80c7/nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java#L430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---