You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (Created) (JIRA)" <ji...@apache.org> on 2011/10/21 01:46:10 UTC
[jira] [Created] (PIVOT-807) Add new "showContentBevel" style to
TerraFrameSkin to allow greater flexibility
Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility
-------------------------------------------------------------------------------
Key: PIVOT-807
URL: https://issues.apache.org/jira/browse/PIVOT-807
Project: Pivot
Issue Type: Improvement
Components: wtk-terra
Affects Versions: 2.0, 2.0.1
Environment: Windows XP SP3, JDK 1.6.0_26
Reporter: Roger Whitcomb
Assignee: Roger Whitcomb
Priority: Minor
Fix For: 2.0.1
The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-807) Add new "showContentBevel" style to
TerraFrameSkin to allow greater flexibility
Posted by "Roger Whitcomb (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb updated PIVOT-807:
---------------------------------
Attachment: frame.patch
This "frame.patch" implements this feature. Not entirely sure I changed all the right constant values -- there are a couple that look suspect to me, but I couldn't see any painting problems by either specifying 'true' or 'false' for the new "showContentBevel' style.
> Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility
> -------------------------------------------------------------------------------
>
> Key: PIVOT-807
> URL: https://issues.apache.org/jira/browse/PIVOT-807
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0, 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_26
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: dialog, frame, skin
> Fix For: 2.0.1
>
> Attachments: frame.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-807) Add new "showContentBevel" style to
TerraFrameSkin to allow greater flexibility
Posted by "Roger Whitcomb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134712#comment-13134712 ]
Roger Whitcomb commented on PIVOT-807:
--------------------------------------
Committed change with Noel's suggestions.
SVN revision 1188501.
> Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility
> -------------------------------------------------------------------------------
>
> Key: PIVOT-807
> URL: https://issues.apache.org/jira/browse/PIVOT-807
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0, 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_26
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: dialog, frame, skin
> Fix For: 2.0.1
>
> Attachments: frame.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-807) Add new "showContentBevel" style to
TerraFrameSkin to allow greater flexibility
Posted by "Roger Whitcomb (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132755#comment-13132755 ]
Roger Whitcomb commented on PIVOT-807:
--------------------------------------
Hi Noel, I guess I was trying to make sure the calculation was consistent everywhere by (essentially) putting it in one place only. But, if you prefer not having another field, then I can do as you suggest.
> Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility
> -------------------------------------------------------------------------------
>
> Key: PIVOT-807
> URL: https://issues.apache.org/jira/browse/PIVOT-807
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0, 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_26
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: dialog, frame, skin
> Fix For: 2.0.1
>
> Attachments: frame.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-807) Add new "showContentBevel" style to
TerraFrameSkin to allow greater flexibility
Posted by "Noel Grandin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132485#comment-13132485 ]
Noel Grandin commented on PIVOT-807:
------------------------------------
Rather than creating a new field on the object, just compute the value in each method that needs it:
int contentBevelHeight = showContentBevel ? 1 : 0;
> Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility
> -------------------------------------------------------------------------------
>
> Key: PIVOT-807
> URL: https://issues.apache.org/jira/browse/PIVOT-807
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0, 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_26
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: dialog, frame, skin
> Fix For: 2.0.1
>
> Attachments: frame.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-807) Add new "showContentBevel" style to
TerraFrameSkin to allow greater flexibility
Posted by "Roger Whitcomb (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Whitcomb resolved PIVOT-807.
----------------------------------
Resolution: Fixed
> Add new "showContentBevel" style to TerraFrameSkin to allow greater flexibility
> -------------------------------------------------------------------------------
>
> Key: PIVOT-807
> URL: https://issues.apache.org/jira/browse/PIVOT-807
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
> Affects Versions: 2.0, 2.0.1
> Environment: Windows XP SP3, JDK 1.6.0_26
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Labels: dialog, frame, skin
> Fix For: 2.0.1
>
> Attachments: frame.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The light-colored so-called "content bevel" is always shown underneath a Frame/Dialog title bar and inside the content border. For our purposes, it would be nice to have the additional flexibility to turn this inside bevel off in order to tweak the appearance of the frame or dialog.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira