[GitHub] reta commented on a change in pull request #490: cxf-rt-transports-udp: cleanup duplicate code -> improve test stability

[GitBox <gi...@apache.org>]

reta commented on a change in pull request #490: cxf-rt-transports-udp: cleanup duplicate code -> improve test stability
URL: https://github.com/apache/cxf/pull/490#discussion_r243985752
 
 

 ##########
 File path: rt/transports/udp/src/main/java/org/apache/cxf/transport/udp/UDPConduit.java
 ##########
 @@ -150,11 +150,7 @@ public void close(Message msg) throws IOException {
             if (s != null && c != null) {
                 c.getSession().removeAttribute(CXF_MESSAGE_ATTR);
 
-                Queue<ConnectFuture> q = connections.get(s);
 
 Review comment:
   The change looks logical but I would recommend to revert it please. There is an issue with `computeIfAbsent` (https://bugs.openjdk.java.net/browse/JDK-8161372) which leads to unnecessary locks and contention on JDKs below 9. Since this is pretty low-level component, under certain conditions it could kill the throughput, I have seen that in the wild. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services