You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/22 00:30:55 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #6982: [HUDI-5045] Adding support to configure index type with integ tests

yihua commented on code in PR #6982:
URL: https://github.com/apache/hudi/pull/6982#discussion_r1002273223


##########
hudi-integ-test/src/main/scala/org/apache/hudi/integ/testsuite/dag/nodes/SparkInsertNode.scala:
##########
@@ -70,6 +70,7 @@ class SparkInsertNode(dagNodeConfig: Config) extends DagNode[RDD[WriteStatus]] {
       .option(DataSourceWriteOptions.PRECOMBINE_FIELD.key(), "test_suite_source_ordering_field")
       .option(DataSourceWriteOptions.TABLE_NAME.key, context.getHoodieTestSuiteWriter.getCfg.targetTableName)
       .option(DataSourceWriteOptions.TABLE_TYPE.key, context.getHoodieTestSuiteWriter.getCfg.tableType)
+      .option("hoodie.index.type", context.getHoodieTestSuiteWriter.getCfg.indexType)

Review Comment:
   nit: could you use the constant variable instead of the scalar String ("hoodie.index.type") to reference the config name here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org