You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Arnab Karmakar (Code Review)" <ge...@cloudera.org> on 2026/10/23 09:00:42 UTC

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Arnab Karmakar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25189


Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................

IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

On Iceberg V3 tables, DEFAULT NULL or DEFAULT CAST(NULL AS <type>) was
sent to catalogd as the text 'NULL' and parsed as a value of the column
type. STRING columns silently got the 4-character string 'NULL' as
their default, and other types failed in catalogd with a raw parse
error.

A NULL default on a nullable column now means no default, which matches
Iceberg semantics. CREATE TABLE and ADD COLUMN(S) set neither
initial-default nor write-default, and ALTER COLUMN SET DEFAULT NULL
drops the write-default like DROP DEFAULT.

Testing:
- Added FE analysis tests and e2e tests in iceberg-v3-default-values.test
  for CREATE TABLE, ADD COLUMN(S) and ALTER COLUMN SET DEFAULT with NULL
  and CAST(NULL AS <type>), on STRING and non-STRING columns.

Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
7 files changed, 100 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/25189/1
-- 
To view, visit http://gerrit.cloudera.org:8080/25189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 2:

(3 comments)

Thanks for the comments!

https://gerrit.cloudera.org/#/c/25189/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

https://gerrit.cloudera.org/#/c/25189/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@108
PS1, Line 108:       if (isDropDefault_ || newColDef_.isIcebergSqlNullDefault()) {
> On a required column, SET DEFAULT NULL now silently drops the write-default
Thanks for catching the bug! Done.


https://gerrit.cloudera.org/#/c/25189/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

https://gerrit.cloudera.org/#/c/25189/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@612
PS1, Line 612:     AnalysisError(v1Tbl + "alter column id set default null",
> iceberg_non_partitioned is format-version 1, so this locks in the V1 behavi
Done and added required-column error coverage in e2e tests.


https://gerrit.cloudera.org/#/c/25189/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test:

https://gerrit.cloudera.org/#/c/25189/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test@585
PS1, Line 585: ====
> The Jira's catalogd failures for non-STRING types were ADD COLUMN b BOOLEAN
Done



-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 18:44:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14316/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/25189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Oct 2026 09:10:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14430/ DRY_RUN=false


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 14:28:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 4: Code-Review+2

LGTM!


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 14:28:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24656/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/25189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Oct 2026 09:25:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.cloudera.org/#/c/25189/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

https://gerrit.cloudera.org/#/c/25189/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@237
PS3, Line 237:       if (alterColumnSetStmt && !isDropDefault_ && newColDef_.hasDefaultValue()) {
The rebase seems to have dropped the PS2 change here. With hasDefaultValue(), SET DEFAULT NULL on a TIMESTAMP or BINARY column fails with "default values not supported", while DROP DEFAULT works. Could this be alterColumnSetStmt && newColDef_.hasIcebergSchemaDefault() (which also covers !isDropDefault_), plus a TIMESTAMP SET DEFAULT NULL test



-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 13:32:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 19:09:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3:

Resolved merge conflicts in PS3.


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Nov 2026 05:49:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    https://gerrit.cloudera.org/25189

to look at the new patch set (#3).

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................

IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

On Iceberg V3 tables, DEFAULT NULL or DEFAULT CAST(NULL AS <type>) was
sent to catalogd as the text 'NULL' and parsed as a value of the column
type. STRING columns silently got the 4-character string 'NULL' as
their default, and other types failed in catalogd with a raw parse
error.

A NULL default on a nullable column now means no default, which matches
Iceberg semantics. CREATE TABLE and ADD COLUMN(S) set neither
initial-default nor write-default, and ALTER COLUMN SET DEFAULT NULL
drops the write-default like DROP DEFAULT.

Testing:
- Added FE analysis tests and e2e tests in iceberg-v3-default-values.test
  for CREATE TABLE, ADD COLUMN(S) and ALTER COLUMN SET DEFAULT with NULL
  and CAST(NULL AS <type>), on STRING and non-STRING columns.

Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
7 files changed, 124 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/25189/3
-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

Thanks for working on this!

https://gerrit.cloudera.org/#/c/25189/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

https://gerrit.cloudera.org/#/c/25189/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@108
PS1, Line 108:       if (isDropDefault_ || newColDef_.isIcebergSqlNullDefault()) {
On a required column, SET DEFAULT NULL now silently drops the write-default, and the
next INSERT that leaves out the column fails at write time. CREATE/ADD reject
NOT NULL DEFAULT NULL ("Default value of NULL not allowed on non-nullable column").
Could we raise the same error here when !column.isNullable() && !isDropDefault_?


https://gerrit.cloudera.org/#/c/25189/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

https://gerrit.cloudera.org/#/c/25189/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@612
PS1, Line 612:     AnalyzesOk(tbl + "alter column id set default null");
iceberg_non_partitioned is format-version 1, so this locks in the V1 behaviour above.
Please use a V3 table here, and add an AnalysisError for V1 plus one for a required column.
If there are no such tables then e2e tests are fine.


https://gerrit.cloudera.org/#/c/25189/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
File testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test:

https://gerrit.cloudera.org/#/c/25189/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test@585
PS1, Line 585: # Non-STRING types: DEFAULT NULL must not be sent as the text 'NULL' to catalogd.
The Jira's catalogd failures for non-STRING types were ADD COLUMN b BOOLEAN DEFAULT NULL and ALTER COLUMN i SET DEFAULT CAST(NULL AS INT). Only CREATE TABLE is covered end to end here. Could you add those two statements?



-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 16:31:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14423/ DRY_RUN=true


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Nov 2026 05:50:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................

IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

On Iceberg V3 tables, DEFAULT NULL or DEFAULT CAST(NULL AS <type>) was
sent to catalogd as the text 'NULL' and parsed as a value of the column
type. STRING columns silently got the 4-character string 'NULL' as
their default, and other types failed in catalogd with a raw parse
error.

A NULL default on a nullable column now means no default, which matches
Iceberg semantics. CREATE TABLE and ADD COLUMN(S) set neither
initial-default nor write-default, and ALTER COLUMN SET DEFAULT NULL
drops the write-default like DROP DEFAULT.

Testing:
- Added FE analysis tests and e2e tests in iceberg-v3-default-values.test
  for CREATE TABLE, ADD COLUMN(S) and ALTER COLUMN SET DEFAULT with NULL
  and CAST(NULL AS <type>), on STRING and non-STRING columns.

Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Reviewed-on: https://gerrit.cloudera.org/25189
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
7 files changed, 140 insertions(+), 10 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14429/ DRY_RUN=true


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 10:04:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 14:43:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24883/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 19:10:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 5
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 14:28:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/24899/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 14:47:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/25189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 1
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Oct 2026 13:38:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    https://gerrit.cloudera.org/25189

to look at the new patch set (#2).

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................

IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

On Iceberg V3 tables, DEFAULT NULL or DEFAULT CAST(NULL AS <type>) was
sent to catalogd as the text 'NULL' and parsed as a value of the column
type. STRING columns silently got the 4-character string 'NULL' as
their default, and other types failed in catalogd with a raw parse
error.

A NULL default on a nullable column now means no default, which matches
Iceberg semantics. CREATE TABLE and ADD COLUMN(S) set neither
initial-default nor write-default, and ALTER COLUMN SET DEFAULT NULL
drops the write-default like DROP DEFAULT.

Testing:
- Added FE analysis tests and e2e tests in iceberg-v3-default-values.test
  for CREATE TABLE, ADD COLUMN(S) and ALTER COLUMN SET DEFAULT with NULL
  and CAST(NULL AS <type>), on STRING and non-STRING columns.

Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
7 files changed, 125 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/25189/2
-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 2
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    https://gerrit.cloudera.org/25189

to look at the new patch set (#4).

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................

IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

On Iceberg V3 tables, DEFAULT NULL or DEFAULT CAST(NULL AS <type>) was
sent to catalogd as the text 'NULL' and parsed as a value of the column
type. STRING columns silently got the 4-character string 'NULL' as
their default, and other types failed in catalogd with a raw parse
error.

A NULL default on a nullable column now means no default, which matches
Iceberg semantics. CREATE TABLE and ADD COLUMN(S) set neither
initial-default nor write-default, and ALTER COLUMN SET DEFAULT NULL
drops the write-default like DROP DEFAULT.

Testing:
- Added FE analysis tests and e2e tests in iceberg-v3-default-values.test
  for CREATE TABLE, ADD COLUMN(S) and ALTER COLUMN SET DEFAULT with NULL
  and CAST(NULL AS <type>), on STRING and non-STRING columns.

Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-default-values.test
7 files changed, 140 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/25189/4
-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Arnab Karmakar (Code Review)" <ge...@cloudera.org>.
Arnab Karmakar has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.cloudera.org/#/c/25189/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

https://gerrit.cloudera.org/#/c/25189/3/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@237
PS3, Line 237:       if (alterColumnSetStmt && newColDef_.hasIcebergSchemaDefault()) {
> The rebase seems to have dropped the PS2 change here. With hasDefaultValue(
Thanks for the catch, yeah right.
The validation line now uses hasIcebergSchemaDefault(), so SET DEFAULT NULL on TIMESTAMP and BINARY passes, and DROP DEFAULT is covered too. Ive also added a test case for TIMESTAMP/ BINARY SET DEFAULT NULL



-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 09 Nov 2026 14:24:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24890/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Nov 2026 06:15:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/25189 )

Change subject: IMPALA-15616: Treat DEFAULT NULL on nullable Iceberg columns as no default
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/14423/


-- 
To view, visit https://gerrit.cloudera.org/25189
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d8909ca0004c1eb7fcf3cc1dc9952679ce70eda
Gerrit-Change-Number: 25189
Gerrit-PatchSet: 3
Gerrit-Owner: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Arnab Karmakar <ar...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 07 Nov 2026 12:07:48 +0000
Gerrit-HasComments: No