You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Sean Schofield <se...@gmail.com> on 2006/04/10 04:05:34 UTC

Re: Provide Patch / Cancel Patch

Done.  Users must have the same permissions as for Create Issue (which
is to say they must be logged in.)

Sean

On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> I'm wondering if it'd be possible to restrict "Provide Patch" to
> logged-in users.
> It's annoying when an anonymous user triggers this with a patch
> because there's no way to identify them in order to educate them as to
> why it was the wrong thing to do.
>
> On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > Is there any way to have the JIRA notification mail state when one of
> > these buttons was pushed?
> >
> > Right now we only get the following (Anon said there was a patch; I
> > cancelled the process because there wasn't one).
> >
> >
> > Anonymous (JIRA)
> >     [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> >  updated TOMAHAWK-134:
> >
> > Mike Kienenberger (JIRA)
> >     [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> > Mike Kienenberger updated TOMAHAWK-134:
> >
>

Re: Provide Patch / Cancel Patch

Posted by Sean Schofield <se...@gmail.com>.
Hmmm. When I went to add it I noticed that the state is part of the
Derby workflow.  They probably took it out ;-)  Lemme see if we can
add our own.

Sean

On 4/12/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > On 4/12/06, Sean Schofield <se...@gmail.com> wrote:
> > > Was there ever a cancel patch option?  My guess is no.  But I can try
> > > to add one ;-)
>
> On 2/27/06, Sean Schofield <se...@gmail.com> wrote:
> > I added
> > a "Cancel Patch" operation.  For now it just dumps you to "Open" even
> > if the status beforehand was "Reopened."  No big deal IMO.  Its more
> > important that we get the patch status correct.
>

Re: Provide Patch / Cancel Patch

Posted by Mike Kienenberger <mk...@gmail.com>.
> On 4/12/06, Sean Schofield <se...@gmail.com> wrote:
> > Was there ever a cancel patch option?  My guess is no.  But I can try
> > to add one ;-)

On 2/27/06, Sean Schofield <se...@gmail.com> wrote:
> I added
> a "Cancel Patch" operation.  For now it just dumps you to "Open" even
> if the status beforehand was "Reopened."  No big deal IMO.  Its more
> important that we get the patch status correct.

Re: Provide Patch / Cancel Patch

Posted by Mike Kienenberger <mk...@gmail.com>.
On 4/12/06, Sean Schofield <se...@gmail.com> wrote:
> Was there ever a cancel patch option?  My guess is no.  But I can try
> to add one ;-)

Yes, there was a cancel patch option right up until your last change.
I was using it multiple times per date to cancel out incorrect
Anonymous "Provide Patch" workflows.   I'm pretty sure you even added
it!

Re: Provide Patch / Cancel Patch

Posted by Sean Schofield <se...@gmail.com>.
Was there ever a cancel patch option?  My guess is no.  But I can try
to add one ;-)

Sean

On 4/10/06, Mike Kienenberger <mk...@gmail.com> wrote:
> Hey Sean,
>
> I went to go fix issue TOMAHAWK-210 one last time, but now there's no
> "Cancel Patch" option available for any issues with a patch.
> "Provide Patch" still shows up, though.  I'm logged in and can even
> edit issues.
>
> On 4/8/06, Anonymous (JIRA) <de...@myfaces.apache.org> wrote:
> >      [ http://issues.apache.org/jira/browse/TOMAHAWK-210?page=all ]
> >
> >  updated TOMAHAWK-210:
> > ----------------------
> >
> >     Status: Patch Available  (was: Open)
>
>
> On 4/9/06, Sean Schofield <se...@gmail.com> wrote:
> > Done.  Users must have the same permissions as for Create Issue (which
> > is to say they must be logged in.)
> >
> > Sean
> >
> > On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > > I'm wondering if it'd be possible to restrict "Provide Patch" to
> > > logged-in users.
> > > It's annoying when an anonymous user triggers this with a patch
> > > because there's no way to identify them in order to educate them as to
> > > why it was the wrong thing to do.
> > >
> > > On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > > > Is there any way to have the JIRA notification mail state when one of
> > > > these buttons was pushed?
> > > >
> > > > Right now we only get the following (Anon said there was a patch; I
> > > > cancelled the process because there wasn't one).
> > > >
> > > >
> > > > Anonymous (JIRA)
> > > >     [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> > > >  updated TOMAHAWK-134:
> > > >
> > > > Mike Kienenberger (JIRA)
> > > >     [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> > > > Mike Kienenberger updated TOMAHAWK-134:
> > > >
> > >
> >
>

Re: Provide Patch / Cancel Patch

Posted by Mike Kienenberger <mk...@gmail.com>.
Hey Sean,

I went to go fix issue TOMAHAWK-210 one last time, but now there's no
"Cancel Patch" option available for any issues with a patch.  
"Provide Patch" still shows up, though.  I'm logged in and can even
edit issues.

On 4/8/06, Anonymous (JIRA) <de...@myfaces.apache.org> wrote:
>      [ http://issues.apache.org/jira/browse/TOMAHAWK-210?page=all ]
>
>  updated TOMAHAWK-210:
> ----------------------
>
>     Status: Patch Available  (was: Open)


On 4/9/06, Sean Schofield <se...@gmail.com> wrote:
> Done.  Users must have the same permissions as for Create Issue (which
> is to say they must be logged in.)
>
> Sean
>
> On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > I'm wondering if it'd be possible to restrict "Provide Patch" to
> > logged-in users.
> > It's annoying when an anonymous user triggers this with a patch
> > because there's no way to identify them in order to educate them as to
> > why it was the wrong thing to do.
> >
> > On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> > > Is there any way to have the JIRA notification mail state when one of
> > > these buttons was pushed?
> > >
> > > Right now we only get the following (Anon said there was a patch; I
> > > cancelled the process because there wasn't one).
> > >
> > >
> > > Anonymous (JIRA)
> > >     [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> > >  updated TOMAHAWK-134:
> > >
> > > Mike Kienenberger (JIRA)
> > >     [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> > > Mike Kienenberger updated TOMAHAWK-134:
> > >
> >
>

Re: Provide Patch / Cancel Patch

Posted by Mike Kienenberger <mk...@gmail.com>.
On 4/13/06, Sean Schofield <se...@gmail.com> wrote:
> Sorry, I got mixed up while fixing the workflow.  There are two
> separate concepts: 1.) workflow, 2.) workflow scheme.  I had only
> changed the scheme but it was pointing to the wrong workflow.  It
> should be fixed now.

I'm able to cancel patches again.  I haven't tested to insure that
anonymous users can't provide them, but I'm sure some anonymous user
will step forward and let us know if it's still possible :)

Re: Provide Patch / Cancel Patch

Posted by Sean Schofield <se...@gmail.com>.
Sorry, I got mixed up while fixing the workflow.  There are two
separate concepts: 1.) workflow, 2.) workflow scheme.  I had only
changed the scheme but it was pointing to the wrong workflow.  It
should be fixed now.

Sean

On 4/13/06, Volker Weber <us...@weber-oldenburg.de> wrote:
> Hi Sean,
>
> are you sure? It looks like just a anonymous user triggers this, see
>
> http://issues.apache.org/jira/browse/TOBAGO-54?page=all
>
>
>
> Regards,
>   Volker
>
>
> Sean Schofield wrote:
> > Done.  Users must have the same permissions as for Create Issue (which
> > is to say they must be logged in.)
> >
> > Sean
> >
> > On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> >
> >>I'm wondering if it'd be possible to restrict "Provide Patch" to
> >>logged-in users.
> >>It's annoying when an anonymous user triggers this with a patch
> >>because there's no way to identify them in order to educate them as to
> >>why it was the wrong thing to do.
> >>
> >>On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> >>
> >>>Is there any way to have the JIRA notification mail state when one of
> >>>these buttons was pushed?
> >>>
> >>>Right now we only get the following (Anon said there was a patch; I
> >>>cancelled the process because there wasn't one).
> >>>
> >>>
> >>>Anonymous (JIRA)
> >>>    [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> >>> updated TOMAHAWK-134:
> >>>
> >>>Mike Kienenberger (JIRA)
> >>>    [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
> >>>Mike Kienenberger updated TOMAHAWK-134:
> >>>
> >>
> >
>
> --
> Don't answer to From: address!
> Mail to this account are droped if not recieved via mailinglist.
> To contact me direct create the mail address by
> concatenating my forename to my senders domain.
>

Re: Provide Patch / Cancel Patch

Posted by Volker Weber <us...@weber-oldenburg.de>.
Hi Sean,

are you sure? It looks like just a anonymous user triggers this, see

http://issues.apache.org/jira/browse/TOBAGO-54?page=all



Regards,
  Volker


Sean Schofield wrote:
> Done.  Users must have the same permissions as for Create Issue (which
> is to say they must be logged in.)
> 
> Sean
> 
> On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
> 
>>I'm wondering if it'd be possible to restrict "Provide Patch" to
>>logged-in users.
>>It's annoying when an anonymous user triggers this with a patch
>>because there's no way to identify them in order to educate them as to
>>why it was the wrong thing to do.
>>
>>On 3/21/06, Mike Kienenberger <mk...@gmail.com> wrote:
>>
>>>Is there any way to have the JIRA notification mail state when one of
>>>these buttons was pushed?
>>>
>>>Right now we only get the following (Anon said there was a patch; I
>>>cancelled the process because there wasn't one).
>>>
>>>
>>>Anonymous (JIRA)
>>>    [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
>>> updated TOMAHAWK-134:
>>>
>>>Mike Kienenberger (JIRA)
>>>    [ http://issues.apache.org/jira/browse/TOMAHAWK-134?page=all ]
>>>Mike Kienenberger updated TOMAHAWK-134:
>>>
>>
> 

-- 
Don't answer to From: address!
Mail to this account are droped if not recieved via mailinglist.
To contact me direct create the mail address by
concatenating my forename to my senders domain.