You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2021/10/08 17:11:19 UTC

[GitHub] [incubator-streampipes-extensions] Hrushi20 opened a new pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Hrushi20 opened a new pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49


   #### Purpose
   Splitting streampipes-connect-adapters module into streampipes-connect-adapters & streampipes-connect-adapters-iiot.
    
   #### Approach
   I split the streampipes-connect module into streampies-connect & streampipes-connect-iiot modules. 
   
   #### Samples
   
   ![Screenshot from 2021-10-08 22-24-50](https://user-images.githubusercontent.com/65367566/136596330-1fff1b0e-3cb3-4a56-a684-14302fb808ef.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-939235688


   Hi Hrushikesh,
   thanks a lot for providing the pull request :)
   
   I checked it out and tested it locally and everything worked fine.
   I have some minor changes for the code before I can merge the pull request:
   
   - In the ConnectAdapterInit you can also add all the adapters (e.g. Gdelt) that were commented out before
   - You can also delete all the classes and packages of the adapters that are not registered in the Init class. Currently the implementation of an adapter / protocol is in both packages.
   - Can you please remove the '/.idea/workspace.xml' file from the commit I think this is a file describing your local setup of IntelliJ.
   
   If you have any questions we can directly discuss them here.
   
   Philipp
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940381645


   Hi
   The api of the streampipes connect has completely been changed. I am getting a lot of errors. The project which I forked is 4 commits behind. How do I fix this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940400794


   Hi
   I get this error while running the streampipes-connect-adapters. I fixed all the conflicts in the file and removed all the unnecessary files in the modules. The IIot modules is working properly. The streampipes-connect-adapters throws this error while running the project.
   
   
   >**java: method guessSchma in class org.apache.streampipes.connect.adapter.guess.SchemaGuesser cannot be applied to given types;
     required: org.apache.streampipes.model.schema.EventSchema,java.util.List<java.util.Map<java.lang.String,java.lang.Object>>
     found: org.apache.streampipes.model.schema.EventSchema
     reason: actual and formal argument lists differ in length**
   
   Not able to fix this issue.
   Thank You.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940410502


   I pushed the latest code but while building the streampipes-connect-adapters an error is being displayed as mentioned above. I am not sure if this is an internal error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] Hrushi20 commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
Hrushi20 commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940286675


   Hi
   What classes and packages do I delete from the adapters that are not registered in the init class?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] Hrushi20 edited a comment on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
Hrushi20 edited a comment on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940286675


   Hi
   What classes and packages do I delete from the modules that are not registered in the init class?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] Hrushi20 removed a comment on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
Hrushi20 removed a comment on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940381645


   Hi
   The api of the streampipes connect has completely been changed. I am getting a lot of errors. The project which I forked is 4 commits behind. How do I fix this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940419123


   Ok, thank you. I will test the code, merge it and resolve the issue you mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] tenthe commented on pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
tenthe commented on pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49#issuecomment-940298680


   E.g. the Plc4xS7Adapter is registered in the IIoT module, so you can remove the code from the streampipes-connect-adapters module. The same applies to the protocols e.g. HttpStreamProtocol is also in the IIoT module and can thus be deleted from the module streampipes-connect-adapters


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampipes-extensions] tenthe merged pull request #49: [STREAMPIPES-] Splitting streampipes-connect-adapters

Posted by GitBox <gi...@apache.org>.
tenthe merged pull request #49:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/49


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org