You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/12/23 17:50:41 UTC

[GitHub] incubator-brooklyn pull request: Fixes SERVICE_UP timeout error in...

GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/425

    Fixes SERVICE_UP timeout error in tests

    Fixes "Caused by: java.lang.IllegalStateException: Timeout waiting for SERVICE_UP from MyServiceImpl" frequently sabotaging the windows CI build.
    MyServiceImpl is setting SERVICE_UP manually while the enrichers toggle it in parallel in response to the SERVICE_STATE_ACTUAL changes. Sometimes the enricher will trigger in the window between MyServiceImpl setting the value to true and calling waitForServiceUp, leading to the timeout error.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/service_up-timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #425
    
----
commit 97ed01e3b2aea770ba58c08b18cc776a5915b2d0
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date:   2014-12-23T16:49:12Z

    Fixes SERVICE_UP timeout error in tests
    
    Fixes "Caused by: java.lang.IllegalStateException: Timeout waiting for SERVICE_UP from MyServiceImpl"
    MyServiceImpl is setting SERVICE_UP manually while the enrichers toggle it in parallel in response to the SERVICE_STATE_ACTUAL changes. Sometimes the enricher will trigger in the window between MyServiceImpl setting the value to true and calling waitForServiceUp, leading to the timeout error.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes SERVICE_UP timeout error in...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes SERVICE_UP timeout error in...

Posted by neykov <gi...@git.apache.org>.

Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/425#issuecomment-69014064
  
    Fixed the test - no need to check for SERVICE_UP as it's a derivative of SERVICE_PROCESS_IS_RUNNING.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Fixes SERVICE_UP timeout error in...

Posted by sjcorbett <gi...@git.apache.org>.

Github user sjcorbett commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/425#issuecomment-68724446
  
    The test failure is repeatable locally. @neykov for your convenience the test is ScriptHelperTest.testCheckRunningForcesInessential.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---