[jira] [Commented] (TEZ-4229) Improve TezLocalCacheManager to use configured root directory

["Panagiotis Garefalakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212244#comment-17212244 ] 

Panagiotis Garefalakis commented on TEZ-4229:
---------------------------------------------

LGTM +1 

> Improve TezLocalCacheManager to use configured root directory
> -------------------------------------------------------------
>
>                 Key: TEZ-4229
>                 URL: https://issues.apache.org/jira/browse/TEZ-4229
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>             Fix For: 0.10.1
>
>         Attachments: TEZ-4229.01.patch, TEZ-4229.01.patch
>
>
> I've just found that in case of some hive unit tests, running on tez local mode, some files are created in current directory, and even if they are cleaned up, it can be confusing to see files that touch git status.
> Repro:
> {code}
> mvn test -Pitests,hadoop-2 -Dtest=TestMmCompactorOnTez -pl ./itests/hive-unit
> #in another terminal
> cd itests/hive-unit
> watch -n 1 "git status"
> {code}
> where git status shows a dirty working directory:
> {code}
>   (use "git add <file>..." to include in what will be committed)
>         itests/hive-unit/tez-conf.pb
>         itests/hive-unit/tez-local-cache199842840233453791/
> {code}
> Both [tempDir|https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/launcher/TezLocalCacheManager.java#L66] and [localize root dir|https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/dag/app/launcher/TezLocalCacheManager.java#L75] might respect the new setting instead of using Paths.get(".")



--
This message was sent by Atlassian Jira
(v8.3.4#803005)