[GitHub] [calcite] woonsan commented on pull request #2621: [CALCITE-4908] Support classpath resource name as model resource path too

[GitBox <gi...@apache.org>]

woonsan commented on pull request #2621:
URL: https://github.com/apache/calcite/pull/2621#issuecomment-1000656608


   Thanks @vlsi !
   
   I've rephrased the docs to use classpath resource name or path consistently, not 'URI' any more. Looking at `Class.getResource(String name)` API doc, the `name` is just a Java-specific 'path', not anything like 'URI'.
   Regarding support for the thread's current context classloader's resource loading, I'm not sure if it is really necessary, practically speaking.
   
   If someone wants to put calcite-core.jar in a shared classloader while trying to load the model classpath resource in an sub-classloader in some container env, it could be a problem to them. Even in that case, I'd recommend them to deploy calcite-core.jar in their specific app (in sub-classloader), for safety. There could be a good use case in a new emerging env in the future too, but I'd rather wait for hearing about a practical use case first.
   
   Thanks,
   
   Woonsan


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org