[jira] [Commented] (AMQ-3135) ActiveMQ.Advisory.Connection messages should contain client ip/host

["R.I.Pienaar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034731#comment-13034731 ] 

R.I.Pienaar commented on AMQ-3135:
----------------------------------

I've tried this in the latest 5.6-SNAPSHOT, it works for simple client connections but the format of the clientIP is a bit odd:

  "clientIp": "/127.0.0.1:48334",

would be great if we could toss out the / or just make it tcp://...  which would be in line with the other cases like:

  "clientIp": "vm://localhost#6",

In the case of broker to broker comms I see:

  "clientId": "monitor1-monitor2_localhost_inbound_localhost",
  "clientIp": "vm://localhost#4",

but never ones showing the tcp connection to the remote broker

> ActiveMQ.Advisory.Connection messages should contain client ip/host
> -------------------------------------------------------------------
>
>                 Key: AMQ-3135
>                 URL: https://issues.apache.org/jira/browse/AMQ-3135
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.4.2
>         Environment: CentOS, OpenJDK 6, ActiveMQ 5.4.2
>            Reporter: R.I.Pienaar
>            Assignee: Dejan Bosanac
>            Priority: Minor
>             Fix For: 5.6.0
>
>
> At present a connection advisory message recieved over stomp looks like:
> "ConnectionInfo": {
>   "commandId": 0,
>   "responseRequired": true,
>   "connectionId": {
>     "value": "ID:monitor1.xx.net-57901-1294599217160-5:10017"
>   },
>   "clientId": "ID:monitor1.xx.net-57901-1294599217160-5:10017",
>   "userName": "",
>   "password": "",
>   "brokerMasterConnector": false,
>   "manageable": false,
>   "clientMaster": true,
>   "faultTolerant": false,
>   "failoverReconnect": false
> }}
> Where monitor1.xx.net is the broker name.
> It would be very useful if these messages also included the IP Address, Hostname, Port of the client connecting.
> There other advisories that would also greatly benefit from this like ActiveMQ.Advisory.NetworkBridge
> thanks

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira