[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #442: Expose complete Tracing APIs in the tracing toolkit

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #442:
URL: https://github.com/apache/skywalking-java/pull/442#discussion_r1083387608


##########
apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/resources/skywalking-plugin.def:
##########
@@ -19,4 +19,10 @@ toolkit-trace=org.apache.skywalking.apm.toolkit.activation.trace.TraceAnnotation
 toolkit-trace=org.apache.skywalking.apm.toolkit.activation.trace.TraceContextActivation
 toolkit-trace=org.apache.skywalking.apm.toolkit.activation.trace.CallableOrRunnableActivation
 toolkit-tag=org.apache.skywalking.apm.toolkit.activation.trace.TagAnnotationActivation
-toolkit-exception=org.apache.skywalking.apm.toolkit.activation.trace.IgnoredExceptionAnnotationActivation
\ No newline at end of file
+toolkit-exception=org.apache.skywalking.apm.toolkit.activation.trace.IgnoredExceptionAnnotationActivation
+toolkit-tracer=org.apache.skywalking.apm.toolkit.activation.trace.CarrierItemRefActivation

Review Comment:
   This should be added into plugin-list.md, as a new name means these instrumentations could be disabled through this name.
   So we check consistent with docs to keep updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org