You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/04/09 21:43:26 UTC
Re: Review Request 20018: Added statistics to Metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 9, 2014, 12:43 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
rebased to 20015
Summary (updated)
-----------------
Added statistics to Metrics.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am c785c4dd852eacaec1be11c68e0b0b95a328d96b
3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION
3rdparty/libprocess/include/process/metrics/metrics.hpp PRE-CREATION
3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review40144
-----------------------------------------------------------
Bad patch!
Reviews applied: [20015, 20018]
Failed command: make check
Error:
Making check in .
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
make[1]: Nothing to be done for `check-am'.
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot'
Making check in 3rdparty
make[1]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make check-recursive
make[2]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
Making check in libprocess
make[3]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
Making check in 3rdparty
make[4]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make check-recursive
make[5]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
Making check in stout
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[6]: Nothing to be done for `check'.
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[6]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make libgmock.la stout-tests
make[7]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[7]: `libgmock.la' is up to date.
make[7]: `stout-tests' is up to date.
make[7]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make check-local
make[7]: Entering directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
./stout-tests
[==========] Running 121 tests from 24 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from Stout
[ RUN ] Stout.Bytes
[ OK ] Stout.Bytes (0 ms)
[ RUN ] Stout.Set
[ OK ] Stout.Set (135 ms)
[ RUN ] Stout.Some
[ OK ] Stout.Some (9 ms)
[----------] 3 tests from Stout (144 ms total)
[----------] 4 tests from Cache
[ RUN ] Cache.Insert
[ OK ] Cache.Insert (0 ms)
[ RUN ] Cache.Update
[ OK ] Cache.Update (0 ms)
[ RUN ] Cache.Erase
[ OK ] Cache.Erase (0 ms)
[ RUN ] Cache.LRUEviction
[ OK ] Cache.LRUEviction (0 ms)
[----------] 4 tests from Cache (0 ms total)
[----------] 4 tests from DurationTest
[ RUN ] DurationTest.Comparison
[ OK ] DurationTest.Comparison (0 ms)
[ RUN ] DurationTest.ParseAndTry
[ OK ] DurationTest.ParseAndTry (23 ms)
[ RUN ] DurationTest.Arithmetic
[ OK ] DurationTest.Arithmetic (0 ms)
[ RUN ] DurationTest.OutputFormat
[ OK ] DurationTest.OutputFormat (3 ms)
[----------] 4 tests from DurationTest (26 ms total)
[----------] 1 test from ErrorTest
[ RUN ] ErrorTest.Test
[ OK ] ErrorTest.Test (0 ms)
[----------] 1 test from ErrorTest (0 ms total)
[----------] 12 tests from FlagsTest
[ RUN ] FlagsTest.Load
[ OK ] FlagsTest.Load (0 ms)
[ RUN ] FlagsTest.Add
[ OK ] FlagsTest.Add (0 ms)
[ RUN ] FlagsTest.Flags
[ OK ] FlagsTest.Flags (0 ms)
[ RUN ] FlagsTest.LoadFromEnvironment
[ OK ] FlagsTest.LoadFromEnvironment (0 ms)
[ RUN ] FlagsTest.LoadFromCommandLine
[ OK ] FlagsTest.LoadFromCommandLine (0 ms)
[ RUN ] FlagsTest.LoadFromCommandLineWithNonFlags
[ OK ] FlagsTest.LoadFromCommandLineWithNonFlags (1 ms)
[ RUN ] FlagsTest.Stringification
[ OK ] FlagsTest.Stringification (0 ms)
[ RUN ] FlagsTest.DuplicatesFromEnvironment
[ OK ] FlagsTest.DuplicatesFromEnvironment (0 ms)
[ RUN ] FlagsTest.DuplicatesFromCommandLine
[ OK ] FlagsTest.DuplicatesFromCommandLine (0 ms)
[ RUN ] FlagsTest.Errors
[ OK ] FlagsTest.Errors (0 ms)
[ RUN ] FlagsTest.Usage
[ OK ] FlagsTest.Usage (0 ms)
[ RUN ] FlagsTest.Duration
[ OK ] FlagsTest.Duration (0 ms)
[----------] 12 tests from FlagsTest (1 ms total)
[----------] 1 test from GzipTest
[ RUN ] GzipTest.CompressDecompressString
[ OK ] GzipTest.CompressDecompressString (111 ms)
[----------] 1 test from GzipTest (111 ms total)
[----------] 2 tests from HashMapTest
[ RUN ] HashMapTest.Insert
[ OK ] HashMapTest.Insert (0 ms)
[ RUN ] HashMapTest.Contains
[ OK ] HashMapTest.Contains (0 ms)
[----------] 2 tests from HashMapTest (0 ms total)
[----------] 2 tests from HashsetTest
[ RUN ] HashsetTest.Insert
[ OK ] HashsetTest.Insert (0 ms)
[ RUN ] HashsetTest.Union
[ OK ] HashsetTest.Union (0 ms)
[----------] 2 tests from HashsetTest (0 ms total)
[----------] 8 tests from IntervalTest
[ RUN ] IntervalTest.Interval
[ OK ] IntervalTest.Interval (0 ms)
[ RUN ] IntervalTest.EmptyInterval
[ OK ] IntervalTest.EmptyInterval (0 ms)
[ RUN ] IntervalTest.Constructor
[ OK ] IntervalTest.Constructor (0 ms)
[ RUN ] IntervalTest.Addition
[ OK ] IntervalTest.Addition (0 ms)
[ RUN ] IntervalTest.Subtraction
[ OK ] IntervalTest.Subtraction (0 ms)
[ RUN ] IntervalTest.Intersection
[ OK ] IntervalTest.Intersection (0 ms)
[ RUN ] IntervalTest.LargeInterval
[ OK ] IntervalTest.LargeInterval (0 ms)
[ RUN ] IntervalTest.IntervalIteration
[ OK ] IntervalTest.IntervalIteration (0 ms)
[----------] 8 tests from IntervalTest (0 ms total)
[----------] 8 tests from JsonTest
[ RUN ] JsonTest.DefaultValueIsNull
[ OK ] JsonTest.DefaultValueIsNull (0 ms)
[ RUN ] JsonTest.BinaryData
[ OK ] JsonTest.BinaryData (0 ms)
[ RUN ] JsonTest.NumberFormat
[ OK ] JsonTest.NumberFormat (0 ms)
[ RUN ] JsonTest.BooleanFormat
[ OK ] JsonTest.BooleanFormat (0 ms)
[ RUN ] JsonTest.BooleanAssignement
[ OK ] JsonTest.BooleanAssignement (0 ms)
[ RUN ] JsonTest.CStringAssignment
[ OK ] JsonTest.CStringAssignment (0 ms)
[ RUN ] JsonTest.NumericAssignment
[ OK ] JsonTest.NumericAssignment (0 ms)
[ RUN ] JsonTest.parse
[ OK ] JsonTest.parse (0 ms)
[----------] 8 tests from JsonTest (0 ms total)
[----------] 5 tests from LinkedHashmapTest
[ RUN ] LinkedHashmapTest.Put
[ OK ] LinkedHashmapTest.Put (0 ms)
[ RUN ] LinkedHashmapTest.Contains
[ OK ] LinkedHashmapTest.Contains (0 ms)
[ RUN ] LinkedHashmapTest.Erase
[ OK ] LinkedHashmapTest.Erase (0 ms)
[ RUN ] LinkedHashmapTest.Keys
[ OK ] LinkedHashmapTest.Keys (0 ms)
[ RUN ] LinkedHashmapTest.Values
[ OK ] LinkedHashmapTest.Values (1 ms)
[----------] 5 tests from LinkedHashmapTest (1 ms total)
[----------] 6 tests from MultimapTest/0, where TypeParam = Multimap<std::string, unsigned short>
[ RUN ] MultimapTest/0.Put
[ OK ] MultimapTest/0.Put (0 ms)
[ RUN ] MultimapTest/0.Remove
[ OK ] MultimapTest/0.Remove (0 ms)
[ RUN ] MultimapTest/0.Size
[ OK ] MultimapTest/0.Size (0 ms)
[ RUN ] MultimapTest/0.Keys
[ OK ] MultimapTest/0.Keys (0 ms)
[ RUN ] MultimapTest/0.Iterator
[ OK ] MultimapTest/0.Iterator (0 ms)
[ RUN ] MultimapTest/0.Foreach
[ OK ] MultimapTest/0.Foreach (0 ms)
[----------] 6 tests from MultimapTest/0 (0 ms total)
[----------] 6 tests from MultimapTest/1, where TypeParam = multihashmap<std::string, unsigned short>
[ RUN ] MultimapTest/1.Put
[ OK ] MultimapTest/1.Put (0 ms)
[ RUN ] MultimapTest/1.Remove
[ OK ] MultimapTest/1.Remove (0 ms)
[ RUN ] MultimapTest/1.Size
[ OK ] MultimapTest/1.Size (0 ms)
[ RUN ] MultimapTest/1.Keys
[ OK ] MultimapTest/1.Keys (0 ms)
[ RUN ] MultimapTest/1.Iterator
[ OK ] MultimapTest/1.Iterator (0 ms)
[ RUN ] MultimapTest/1.Foreach
[ OK ] MultimapTest/1.Foreach (0 ms)
[----------] 6 tests from MultimapTest/1 (0 ms total)
[----------] 4 tests from NetTest
[ RUN ] NetTest.mac
[ OK ] NetTest.mac (12 ms)
[ RUN ] NetTest.ConstructMAC
[ OK ] NetTest.ConstructMAC (0 ms)
[ RUN ] NetTest.ip
[ OK ] NetTest.ip (0 ms)
[ RUN ] NetTest.ConstructIP
[ OK ] NetTest.ConstructIP (1 ms)
[----------] 4 tests from NetTest (13 ms total)
[----------] 1 test from NoneTest
[ RUN ] NoneTest.Test
[ OK ] NoneTest.Test (0 ms)
[----------] 1 test from NoneTest (0 ms total)
[----------] 3 tests from OptionTest
[ RUN ] OptionTest.Min
[ OK ] OptionTest.Min (0 ms)
[ RUN ] OptionTest.Max
[ OK ] OptionTest.Max (0 ms)
[ RUN ] OptionTest.Comparison
[ OK ] OptionTest.Comparison (0 ms)
[----------] 3 tests from OptionTest (0 ms total)
[----------] 18 tests from OsTest
[ RUN ] OsTest.environment
[ OK ] OsTest.environment (37 ms)
[ RUN ] OsTest.rmdir
[ OK ] OsTest.rmdir (38 ms)
[ RUN ] OsTest.system
sh: 1: invalid.command: not found
[ OK ] OsTest.system (347 ms)
[ RUN ] OsTest.nonblock
[ OK ] OsTest.nonblock (8 ms)
[ RUN ] OsTest.touch
[ OK ] OsTest.touch (16 ms)
[ RUN ] OsTest.readWriteString
[ OK ] OsTest.readWriteString (21 ms)
[ RUN ] OsTest.find
[ OK ] OsTest.find (9 ms)
[ RUN ] OsTest.bootId
[ OK ] OsTest.bootId (0 ms)
[ RUN ] OsTest.uname
[ OK ] OsTest.uname (26 ms)
[ RUN ] OsTest.sysname
[ OK ] OsTest.sysname (0 ms)
[ RUN ] OsTest.release
[ OK ] OsTest.release (0 ms)
[ RUN ] OsTest.sleep
[ OK ] OsTest.sleep (14 ms)
[ RUN ] OsTest.pids
[ OK ] OsTest.pids (311 ms)
[ RUN ] OsTest.children
[ OK ] OsTest.children (60 ms)
[ RUN ] OsTest.process
[ OK ] OsTest.process (7 ms)
[ RUN ] OsTest.processes
[ OK ] OsTest.processes (20 ms)
[ RUN ] OsTest.killtree
[ OK ] OsTest.killtree (111 ms)
[ RUN ] OsTest.pstree
[ OK ] OsTest.pstree (44 ms)
[----------] 18 tests from OsTest (1071 ms total)
[----------] 1 test from ProtobufTest
[ RUN ] ProtobufTest.JSON
[ OK ] ProtobufTest.JSON (7 ms)
[----------] 1 test from ProtobufTest (7 ms total)
[----------] 1 test from OsSendfileTest
[ RUN ] OsSendfileTest.sendfile
[ OK ] OsSendfileTest.sendfile (8 ms)
[----------] 1 test from OsSendfileTest (8 ms total)
[----------] 1 test from OsSignalsTest
[ RUN ] OsSignalsTest.suppress
[ OK ] OsSignalsTest.suppress (0 ms)
[----------] 1 test from OsSignalsTest (0 ms total)
[----------] 22 tests from StringsTest
[ RUN ] StringsTest.Format
[ OK ] StringsTest.Format (0 ms)
[ RUN ] StringsTest.Remove
[ OK ] StringsTest.Remove (0 ms)
[ RUN ] StringsTest.Replace
[ OK ] StringsTest.Replace (0 ms)
[ RUN ] StringsTest.Trim
[ OK ] StringsTest.Trim (0 ms)
[ RUN ] StringsTest.Tokenize
[ OK ] StringsTest.Tokenize (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtStart
[ OK ] StringsTest.TokenizeStringWithDelimsAtStart (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtEnd
[ OK ] StringsTest.TokenizeStringWithDelimsAtEnd (0 ms)
[ RUN ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd
[ OK ] StringsTest.TokenizeStringWithDelimsAtStartAndEnd (0 ms)
[ RUN ] StringsTest.TokenizeWithMultipleDelims
[ OK ] StringsTest.TokenizeWithMultipleDelims (0 ms)
[ RUN ] StringsTest.TokenizeEmptyString
[ OK ] StringsTest.TokenizeEmptyString (0 ms)
[ RUN ] StringsTest.TokenizeDelimOnlyString
[ OK ] StringsTest.TokenizeDelimOnlyString (0 ms)
[ RUN ] StringsTest.TokenizeNullByteDelim
[ OK ] StringsTest.TokenizeNullByteDelim (0 ms)
[ RUN ] StringsTest.SplitEmptyString
[ OK ] StringsTest.SplitEmptyString (0 ms)
[ RUN ] StringsTest.SplitDelimOnlyString
[ OK ] StringsTest.SplitDelimOnlyString (0 ms)
[ RUN ] StringsTest.Split
[ OK ] StringsTest.Split (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtStart
[ OK ] StringsTest.SplitStringWithDelimsAtStart (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtEnd
[ OK ] StringsTest.SplitStringWithDelimsAtEnd (0 ms)
[ RUN ] StringsTest.SplitStringWithDelimsAtStartAndEnd
[ OK ] StringsTest.SplitStringWithDelimsAtStartAndEnd (0 ms)
[ RUN ] StringsTest.SplitWithMultipleDelims
[ OK ] StringsTest.SplitWithMultipleDelims (0 ms)
[ RUN ] StringsTest.Pairs
[ OK ] StringsTest.Pairs (0 ms)
[ RUN ] StringsTest.StartsWith
[ OK ] StringsTest.StartsWith (0 ms)
[ RUN ] StringsTest.Contains
[ OK ] StringsTest.Contains (0 ms)
[----------] 22 tests from StringsTest (1 ms total)
[----------] 1 test from Thread
[ RUN ] Thread.local
[ OK ] Thread.local (0 ms)
[----------] 1 test from Thread (0 ms total)
[----------] 1 test from UUIDTest
[ RUN ] UUIDTest.test
[ OK ] UUIDTest.test (1 ms)
[----------] 1 test from UUIDTest (1 ms total)
[----------] 6 tests from ProcTest
[ RUN ] ProcTest.pids
[ OK ] ProcTest.pids (1 ms)
[ RUN ] ProcTest.cpus
[ OK ] ProcTest.cpus (0 ms)
[ RUN ] ProcTest.SystemStatus
[ OK ] ProcTest.SystemStatus (0 ms)
[ RUN ] ProcTest.ProcessStatus
[ OK ] ProcTest.ProcessStatus (0 ms)
[ RUN ] ProcTest.SingleThread
[ OK ] ProcTest.SingleThread (4 ms)
[ RUN ] ProcTest.MultipleThreads
stout/tests/proc_tests.cpp:164: Failure
read is NONE
[ FAILED ] ProcTest.MultipleThreads (9 ms)
[----------] 6 tests from ProcTest (14 ms total)
[----------] Global test environment tear-down
[==========] 121 tests from 24 test cases ran. (1400 ms total)
[ PASSED ] 120 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ProcTest.MultipleThreads
1 FAILED TEST
make[7]: *** [check-local] Error 1
make[7]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[6]: *** [check-am] Error 2
make[6]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[5]: *** [check-recursive] Error 1
make[5]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[4]: *** [check] Error 2
make[4]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
make[3]: *** [check-recursive] Error 1
make[3]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On April 10, 2014, 10:33 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 10:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
> NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491
> 3rdparty/libprocess/include/process/metrics/metric.hpp ea64f699fd9ec38745d84c7523133709827f96db
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
> 3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
> 3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review40267
-----------------------------------------------------------
This looks like it needs a rebase and then republish the diff?
- Benjamin Hindman
On April 10, 2014, 10:33 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 10:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
> NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491
> 3rdparty/libprocess/include/process/metrics/metric.hpp ea64f699fd9ec38745d84c7523133709827f96db
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
> 3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
> 3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On April 18, 2014, 2:29 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, line 81
> > <https://reviews.apache.org/r/20018/diff/5/?file=562379#file562379line81>
> >
> > Can you describe why you want to do this? We can just make local http requests to get the JSON, right?
expanded comment.
> On April 18, 2014, 2:29 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, lines 116-120
> > <https://reviews.apache.org/r/20018/diff/5/?file=562379#file562379line116>
> >
> > Calling get() will crash if the option is none, are there some hidden semantics here that ensure these are SOME?
it's subtle - the statistics being none indicates the statistics object was created with an empty timeseries. the outer statistics option will already be none in this case as the metric was created without a history window. So if the outer statistics option is some, the inner ones should be some also.
is the preference to avoid a crash in this case by adding a conditional or to add a CHECK to show the explicit relationship?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review40814
-----------------------------------------------------------
On April 18, 2014, 2:47 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 2:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review40814
-----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/metric.hpp
<https://reviews.apache.org/r/20018/#comment73988>
I missed this in the last review, can you use braces for the locked section? This was done in all other uses of internal::acquire/release as it makes it a bit easier to read!
3rdparty/libprocess/src/metrics/metrics.cpp
<https://reviews.apache.org/r/20018/#comment73984>
Can you describe why you want to do this? We can just make local http requests to get the JSON, right?
3rdparty/libprocess/src/metrics/metrics.cpp
<https://reviews.apache.org/r/20018/#comment73983>
Calling get() will crash if the option is none, are there some hidden semantics here that ensure these are SOME?
- Ben Mahler
On April 18, 2014, 7:38 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 7:38 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On April 22, 2014, 12:09 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/statistics.hpp, lines 64-65
> > <https://reviews.apache.org/r/20018/diff/10/?file=564597#file564597line64>
> >
> > Looking around at other libraries, "p999" and "p9999" seem to be pretty standard so I take back that this might confuse people. Let's revert, sound good?
no problem - i'm surprised that it's standard, but i'll go with it :)
> On April 22, 2014, 12:09 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/statistics.hpp, lines 90-93
> > <https://reviews.apache.org/r/20018/diff/10/?file=564597#file564597line90>
> >
> > Looks like there is a regression here! What happens on line 76 when position is negative? Likely the CHECK_LT on line 86 will fail!
> >
> > This seems more difficult to understand and this change introduces a bug, let's revert!
i just noticed you removed the clamping.
> On April 22, 2014, 12:09 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 144-162
> > <https://reviews.apache.org/r/20018/diff/10/?file=564599#file564599line144>
> >
> > Is this rebased off master? This test looks to be already committed.
it is .. and i'm showing it as being different to master too locally. i'll rebase again, but not sure why it's not showing up in my master (which i pulled this morning).
Are you thinking about the statistics_test.cpp?
> On April 22, 2014, 12:09 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/tests/metrics_tests.cpp, line 149
> > <https://reviews.apache.org/r/20018/diff/10/?file=564599#file564599line149>
> >
> > size_t?
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Integer_Types#Integer_Types
> On April 22, 2014, 12:09 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 199-216
> > <https://reviews.apache.org/r/20018/diff/10/?file=564599#file564599line199>
> >
> > Is there any reason to overlap the removal of gauge and counter? Could we remove the gauge first to make this a bit easier to follow?
there is, and i'll add a comment explaining it.
> On April 22, 2014, 12:09 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/tests/metrics_tests.cpp, lines 259-263
> > <https://reviews.apache.org/r/20018/diff/10/?file=564599#file564599line259>
> >
> > Can we come up with an interval that generates more intuitive percentiles? One that a reader can intuit?
it's tricky because i want to reset and end up with a non-zero value that isn't the maximum. try this?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review41044
-----------------------------------------------------------
On April 22, 2014, 11:20 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 11:20 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/include/process/statistics.hpp d046bffa00fa839909112f65d19dfb9af46ad2b3
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 478453fd60056603cf2eb96e56ac2df7e47a3e99
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review41044
-----------------------------------------------------------
Almost there!
3rdparty/libprocess/include/process/statistics.hpp
<https://reviews.apache.org/r/20018/#comment74406>
Looking around at other libraries, "p999" and "p9999" seem to be pretty standard so I take back that this might confuse people. Let's revert, sound good?
3rdparty/libprocess/include/process/statistics.hpp
<https://reviews.apache.org/r/20018/#comment74405>
Looks like there is a regression here! What happens on line 76 when position is negative? Likely the CHECK_LT on line 86 will fail!
This seems more difficult to understand and this change introduces a bug, let's revert!
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74412>
Is this rebased off master? This test looks to be already committed.
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74411>
size_t?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74413>
Hm, we probably should check the other percentiles here as well, no?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74414>
This test is pretty difficult to digest, can you add some comments above each logical block describing what you're testing?
s/JSONAddAndRemove/Snapshot/ ?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74415>
s/jsonResponse/expected/?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74417>
Is there any reason to overlap the removal of gauge and counter? Could we remove the gauge first to make this a bit easier to follow?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74409>
Most of our tests in libprocess (a few exceptions) omit the "Test" suffix here, can you s/MetricsTest/Metrics/?
s/JSONStatistics/SnapshotSatistics/ ?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74410>
Increment consistently instead of pre _and_ post here?
Use size_t?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74408>
Can we come up with an interval that generates more intuitive percentiles? One that a reader can intuit?
3rdparty/libprocess/src/tests/statistics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74407>
Thanks! [-5,5] seems much cleaner than the extra 0 and [-5,4]!
- Ben Mahler
On April 22, 2014, 6:20 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 6:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/include/process/statistics.hpp d046bffa00fa839909112f65d19dfb9af46ad2b3
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 478453fd60056603cf2eb96e56ac2df7e47a3e99
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review41077
-----------------------------------------------------------
Ship it!
Alright, I'll get this committed! I made a number of comments for cleanup below but I didn't open them as "issues" since I've included the fixes in the commit.
Please let me know if anything was missed or if we should follow up with anything!
3rdparty/libprocess/src/metrics/metrics.cpp
<https://reviews.apache.org/r/20018/#comment74461>
Let's remove this since 'context' no longer exists.
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74463>
Please no using clause for methods like this since just seeing get() out of context is a bit unintuitive.
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74484>
You don't need EXPECT_FLOAT_EQ for integral double values, right?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74478>
Looks like we could simplify this test to only do what is necessary:
// Ensure JSON is empty.
// Add a counter and gauge.
// Ensure they are present in the JSON.
// Remove them.
// Ensure they are not present in the JSON.
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74475>
Please favor names like "counter" and "gauge" over "c" and "g".
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74477>
It seems like all of our tests in libprocess would need this, no?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74476>
Testing this seems unnecessary, let's opt to keep the test simple instead!
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74471>
s/c/counter/
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74465>
You can remove the need for this call to advance outside the loop by advancing _before_ the counter pre-increment in the loop.
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74470>
Advancing the clock after incrementing does not achieve anything, so does it makes sense to only increment before?
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74469>
Let's move the response down to below the expected object.
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74468>
Let's add some newlines here to make it easier to read.
- Ben Mahler
On April 22, 2014, 7:56 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 7:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 478453fd60056603cf2eb96e56ac2df7e47a3e99
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 22, 2014, 12:56 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
3rdparty/libprocess/src/tests/statistics_tests.cpp 478453fd60056603cf2eb96e56ac2df7e47a3e99
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 22, 2014, 11:20 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
added JSON tests.
percentile variables and JSON output explicitly indicate where the decimal point is.
percentile calculation deals with edge-cases more cleanly.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/include/process/statistics.hpp d046bffa00fa839909112f65d19dfb9af46ad2b3
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
3rdparty/libprocess/src/tests/statistics_tests.cpp 478453fd60056603cf2eb96e56ac2df7e47a3e99
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On April 22, 2014, 12:45 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, lines 81-82
> > <https://reviews.apache.org/r/20018/diff/9/?file=563829#file563829line81>
> >
> > Rather than do this, why not just use http::get as we've done in other tests? That should keep the code simple and still give us tests that match how it will be used!
i always prefer to minimize the test surface - ie, not test the http::get and routing code when i'm trying to test JSON creation. I thought using http:get would be a hack, but if it's what is already used elsewhere it SGTM!
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review41004
-----------------------------------------------------------
On April 21, 2014, 4:02 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 4:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review41004
-----------------------------------------------------------
Last thing I would like to see before committing this one is some JSON tests per my comments below. Was there a reason to not implement these?
Did you at least test manually? 'make check' would not be sufficient to ensure our endpoints are correct here.
3rdparty/libprocess/src/metrics/metrics.cpp
<https://reviews.apache.org/r/20018/#comment74358>
Rather than do this, why not just use http::get as we've done in other tests? That should keep the code simple and still give us tests that match how it will be used!
3rdparty/libprocess/src/tests/metrics_tests.cpp
<https://reviews.apache.org/r/20018/#comment74357>
Any reason these are not implemented? We have support for JSON parsing and equality in stout. Ditto below.
- Ben Mahler
On April 21, 2014, 11:02 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 21, 2014, 11:02 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 21, 2014, 4:02 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 21, 2014, 4:01 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 21, 2014, 3:57 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 21, 2014, 2:21 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
update to factory method, add more percentiles to endpoint. Rebased to latest 20047.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review40859
-----------------------------------------------------------
Bad patch!
Reviews applied: [20047, 20018]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
In file included from ../../../3rdparty/libprocess/include/process/metrics/metrics.hpp:11:0,
from ../../../3rdparty/libprocess/src/metrics/metrics.cpp:12:
../../../3rdparty/libprocess/include/process/metrics/metric.hpp: In member function 'Option<process::Statistics<double> > process::metrics::Metric::statistics() const':
../../../3rdparty/libprocess/include/process/metrics/metric.hpp:35:59: error: no matching function for call to 'process::Statistics<double>::Statistics(process::TimeSeries<double>&)'
../../../3rdparty/libprocess/include/process/metrics/metric.hpp:35:59: note: candidates are:
../../../3rdparty/libprocess/include/process/statistics.hpp:72:12: note: process::Statistics<T>::Statistics(const std::vector<typename process::TimeSeries<T>::Value>&) [with T = double, typename process::TimeSeries<T>::Value = process::TimeSeries<double>::Value]
../../../3rdparty/libprocess/include/process/statistics.hpp:72:12: note: no known conversion for argument 1 from 'process::TimeSeries<double>' to 'const std::vector<process::TimeSeries<double>::Value, std::allocator<process::TimeSeries<double>::Value> >&'
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note: constexpr process::Statistics<double>::Statistics(const process::Statistics<double>&)
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note: no known conversion for argument 1 from 'process::TimeSeries<double>' to 'const process::Statistics<double>&'
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note: constexpr process::Statistics<double>::Statistics(process::Statistics<double>&&)
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note: no known conversion for argument 1 from 'process::TimeSeries<double>' to 'process::Statistics<double>&&'
../../../3rdparty/libprocess/src/metrics/metrics.cpp: In static member function 'static process::Future<process::http::Response> process::metrics::internal::MetricsProcess::_snapshot(const process::http::Request&, const hashmap<std::basic_string<char>, process::Future<double> >&, const hashmap<std::basic_string<char>, Option<process::Statistics<double> > >&)':
../../../3rdparty/libprocess/src/metrics/metrics.cpp:118:54: error: request for member 'get' in '(& statistics)->process::Statistics<T>::min [with T = double]()', which is of non-class type 'double'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:119:54: error: request for member 'get' in '(& statistics)->process::Statistics<T>::max [with T = double]()', which is of non-class type 'double'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:120:48: error: 'const class process::Statistics<double>' has no member named 'median'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:121:48: error: 'const class process::Statistics<double>' has no member named 'percentiles'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:122:48: error: 'const class process::Statistics<double>' has no member named 'percentiles'
make[5]: *** [libprocess_la-metrics.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On April 18, 2014, 10:48 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 10:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
> 3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 18, 2014, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
rebased to percentile struct in 20047.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 18, 2014, 2:47 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
benm's comments
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 18, 2014, 12:38 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
rebased to 20047
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description (updated)
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6c48357a39598b5b0a324ed664366467c0518ebd
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 10, 2014, 3:33 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
rebased to 20015
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491
3rdparty/libprocess/include/process/metrics/metric.hpp ea64f699fd9ec38745d84c7523133709827f96db
3rdparty/libprocess/include/process/metrics/metrics.hpp c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
3rdparty/libprocess/src/metrics/metrics.cpp 391295aea91e837bb856a40ef51d1c33d44371d8
3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
3rdparty/libprocess/src/tests/metrics_tests.cpp 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb
3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review39974
-----------------------------------------------------------
Patch looks great!
Reviews applied: [18718, 20015, 20018]
All tests passed.
- Mesos ReviewBot
On April 10, 2014, 12:31 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 12:31 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
> NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am c785c4dd852eacaec1be11c68e0b0b95a328d96b
> 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/metrics/metrics.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
> 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
> 3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
> 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
> 3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20018: Added statistics to Metrics.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/
-----------------------------------------------------------
(Updated April 9, 2014, 5:31 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
rebased to 18718 changes.
Bugs: MESOS-1036
https://issues.apache.org/jira/browse/MESOS-1036
Repository: mesos-git
Description
-------
see summary.
NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am c785c4dd852eacaec1be11c68e0b0b95a328d96b
3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION
3rdparty/libprocess/include/process/metrics/metrics.hpp PRE-CREATION
3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION
3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/20018/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 20018: Added statistics to Metrics.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review39967
-----------------------------------------------------------
Bad patch!
Reviews applied: [18718, 20015]
Failed command: git apply --index 20015.patch
Error:
error: patch failed: 3rdparty/libprocess/include/process/metrics/counter.hpp:11
error: 3rdparty/libprocess/include/process/metrics/counter.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/metrics/gauge.hpp:18
error: 3rdparty/libprocess/include/process/metrics/gauge.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/metrics/metric.hpp:14
error: 3rdparty/libprocess/include/process/metrics/metric.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/src/tests/metrics_tests.cpp:2
error: 3rdparty/libprocess/src/tests/metrics_tests.cpp: patch does not apply
- Mesos ReviewBot
On April 9, 2014, 7:43 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 7:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
> NOTE: This includes https://reviews.apache.org/r/20047 instead of depending on it as the dependency chain was already getting complex.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am c785c4dd852eacaec1be11c68e0b0b95a328d96b
> 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/metrics/metrics.hpp PRE-CREATION
> 3rdparty/libprocess/include/process/statistics.hpp a4f1db3a8a219c39193a1d237477f0350e47e681
> 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 9654c0437edb43cff65dbefdf08dee9e18ef96ab
> 3rdparty/libprocess/src/statistics.cpp 75aac4074d33cb5054da6c8b0bd4a890c2eaf80e
> 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION
> 3rdparty/libprocess/src/tests/statistics_tests.cpp 3521bd565dae8fcbba464f2539b3b14a37a037f0
> 3rdparty/libprocess/src/timeseries.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>