[GitHub] [incubator-druid] leventov commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

[GitBox <gi...@apache.org>]

leventov commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.
URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-517758347
 
 
   > #3892 is a very long issue that splits into multiple discussions covering many different things, so I am not sure what is the bottom line
   
   There is no bottom line, but there is kind of a "top line" that we want to move to `Memory` from `ByteBuffer`s. This still stands.
   
   > If it is blocked then what is the reason - is it community rejection due to backward compatibility? fear of performance degradation? or simply lack of working hands?
   
   No working hands.
   
   > Does buffer aggregators used by on-heap incremental index or only by off-heap incremental index?
   
   They are used by off-heap incremental index, and in the implementations of queries such as groupBy and topN.
   
   > If the answer to (1) is only off-heap incremental index, then does off-heap incremental index being used in production anywhere? does it perform well enough?
   
   It's used in the implementation of groupBy queries. It's not used more widely, including during the data ingestion specifically because of the unsolved problem with growable complex aggregations - this is what this proposal is all about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org