You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anshula Jain (Code Review)" <ge...@cloudera.org> on 2024/05/20 17:25:39 UTC
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Anshula Jain has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21443
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/1
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 1
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16386/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 2
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Jun 2024 16:58:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 9:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@210
PS4, Line 210: options, args = parser.parse_args()
> This appears to be unused. It's true that most of the time we use_local_cat
Done
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@266
PS4, Line 266: processes = [proc for _, proc in find_user_processes(binary_names)]
> nit: Unnecessary whitespace.
Done
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@361
PS4, Line 361: else:
> nit: Unnecessary whitespace.
Done
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@448
PS4, Line 448: if remap_ports:
> I think this could be simpler. Handle it the same as other options below:
Done
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@685
PS4, Line 685:
> catalog_topic_mode only needs to be set on catalogd.
We still need to set `-use_local_catalog` here.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@688
PS4, Line 688: """If the cluster is kerberized, returns arguments to pass to daemon process.
> If not set, don't specify an option. Tests still set this via impalad_args.
Done
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@719
PS4, Line 719: #
> I don't understand what this is doing.
Done
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 9
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jan 2025 00:29:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/9
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 9
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 29 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/4
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 4
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 29 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/3
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 3
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16400/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 3
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jun 2024 16:36:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 17:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21443/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21443/17//COMMIT_MSG@13
PS17, Line 13: bin/start-impala-cluster.py --use_local_catalog
Whatever we end up with, please update the commit message to reflect the code.
http://gerrit.cloudera.org:8080/#/c/21443/15/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/15/bin/start-impala-cluster.py@204
PS15, Line 204: --use_on_demand_met
> It is also possible to have combination of --catalogd_args=--catalog_topic
I had previously commented I don't think we have a local testing use case for mixed mode. At least not one worth a dedicated argument.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 19:44:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@212
PS17, Line 212: "
flake8: E501 line too long (92 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 18:47:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16188/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 1
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 May 2024 17:49:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18156/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 12
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2025 12:35:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 15: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py@207
PS12, Line 207: "catalogd and cache it locally. The cached metadata gets evicted"
> I don't think we generally use this short-hand in our help messages.
Done
http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py@678
PS12, Line 678: # Appended at the end so they can override previous args.
> I think my point is not getting across completely.
Done
http://gerrit.cloudera.org:8080/#/c/21443/13/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/13/bin/start-impala-cluster.py@682
PS13, Line 682:
> nit: extra whitespace should be removed. It's fine to keep the newline, jus
Done
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 15
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 18:42:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/10
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 10
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py@207
PS12, Line 207: "catalogd & cache it locally. The cached metadata gets evicted"
I don't think we generally use this short-hand in our help messages.
http://gerrit.cloudera.org:8080/#/c/21443/12/bin/start-impala-cluster.py@678
PS12, Line 678: if options.use_local_catalog:
I think my point is not getting across completely.
Line 460 handles the catalogd args list. It looks correct: if use_local_catalog is true, add `-catalog_topic_mode=minimal` for catalogd.
This section in build_impalad_arg_lists handles the impalad args list. It only uses the `use_local_catalog` argument, so there's no need to also set `catalog_topic_mode` here.
Also I'd like to see these be consistent: either include an else clause in both places, or neither. I prefer omitting the else clauses; if we change Impala's default to be to use local catalog mode, then this option in start-impala-cluster will need to be revisited (either to update it to let local catalog be the default, change it to be a flag to disable local catalog, or remove it).
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 12
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 21:17:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 27 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/2
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 2
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 15:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21443/15/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/15/bin/start-impala-cluster.py@204
PS15, Line 204: --use_local_catalog
It is also possible to have combination of --catalogd_args=--catalog_topic_mode=mixed and --impalad_args=--use_local_catalog=true
https://impala.apache.org/docs/build/html/topics/impala_metadata.html
Please rename this combination to something more specific like --use_on_demand_metadata and assert that:
1. catalog_topic_mode not in --catalogd_args
2. use_local_catalog not in --impalad_args
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 15
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Feb 2025 18:49:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/12
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 12
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/15
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 15
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16405/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 4
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Jun 2024 13:48:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21443/3/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/3/bin/start-impala-cluster.py@203
PS3, Line 203: #Adding this to shorten the command to enable local catalog mode IMPALA-12869
flake8: E265 block comment should start with '# '
http://gerrit.cloudera.org:8080/#/c/21443/3/bin/start-impala-cluster.py@204
PS3, Line 204:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21443/3/bin/start-impala-cluster.py@204
PS3, Line 204: parser.add_option("--use_local_catalog", dest="use_local_catalog",
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 3
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Jun 2024 16:12:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 17:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18350/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 19:10:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 15:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18196/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 15
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 18:58:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21443/2/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/2/bin/start-impala-cluster.py@204
PS2, Line 204:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21443/2/bin/start-impala-cluster.py@204
PS2, Line 204: parser.add_option("--use_local_catalog", dest="use_local_catalog",
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21443/2/bin/start-impala-cluster.py@685
PS2, Line 685: )
flake8: E501 line too long (91 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 2
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Jun 2024 17:16:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has uploaded a new patch set (#17). ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
IMPALA-12869: Shorten argument list to enable local catalog mode
Currently, a longer command is used to enable local catalog mode
bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
With this JIRA we shorten the command to
bin/start-impala-cluster.py --use_local_catalog
Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
---
M bin/start-impala-cluster.py
1 file changed, 26 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/21443/17
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/17915/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 9
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Jan 2025 09:52:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 10:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18155/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 10
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Feb 2025 08:58:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21443/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/1/bin/start-impala-cluster.py@190
PS1, Line 190:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21443/1/bin/start-impala-cluster.py@190
PS1, Line 190: parser.add_option("--use_local_catalog", dest="use_local_catalog",
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21443/1/bin/start-impala-cluster.py@644
PS1, Line 644: )
flake8: E501 line too long (91 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 1
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 May 2024 17:26:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 4:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@210
PS4, Line 210: parser.add_option("--catalog_topic_mode", dest="catalog_topic_mode",
This appears to be unused. It's true that most of the time we use_local_catalog=true, we want to set catalog_topic_mode=minimal.
catalog-server.cc notes that 'mixed' mode exists for when some coordinators use local catalog and others don't. We would need to provide coordinator-specific config to use that, so I think we can omit it from the shortcut option. I'd remove the separate catalog_topic_mode option.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@266
PS4, Line 266:
nit: Unnecessary whitespace.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@361
PS4, Line 361:
nit: Unnecessary whitespace.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@448
PS4, Line 448: catalogd_arg_list = [set_catalog_topic_mode(options.use_local_catalog)]
I think this could be simpler. Handle it the same as other options below:
if options.use_local_catalog:
args.extend(["-catalog_topic_mode=minimal"])
use_local_catalog is unnecessary here, it's only used by coordinators.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@685
PS4, Line 685: args = "{args} -use_local_catalog=true -catalog_topic_mode=minimal".format(
catalog_topic_mode only needs to be set on catalogd.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@688
PS4, Line 688: args = "{args} -use_local_catalog=false -catalog_topic_mode=full".format(
If not set, don't specify an option. Tests still set this via impalad_args.
http://gerrit.cloudera.org:8080/#/c/21443/4/bin/start-impala-cluster.py@719
PS4, Line 719: def set_catalog_topic_mode(use_local_catalog):
I don't understand what this is doing.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 4
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 17:59:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 17:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/21443/17//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21443/17//COMMIT_MSG@10
PS17, Line 10: bin/start-impala-cluster.py --catalogd_args=--catalog_topic_mode=minimal --impalad_args=--use_local_catalog
nit: Break this long line to not exceed 72 chars:
bin/start-impala-cluster.py \
--catalogd_args=--catalog_topic_mode=minimal \
--impalad_args=--use_local_catalog
http://gerrit.cloudera.org:8080/#/c/21443/15/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/15/bin/start-impala-cluster.py@204
PS15, Line 204: --use_on_demand_met
> It is also possible to have combination of --catalogd_args=--catalog_topic
The last part of this comment has not been addressed. I will clarify my request in patch set 17.
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@204
PS17, Line 204: parser.add_option("--use_on_demand_metadata", dest="use_on_demand_metadata"
Please edit existing test to prove that this new options work. These are some good candidate:
custom_cluster/test_concurrent_ddls.py::TestConcurrentDdls::test_local_catalog_ddls_with_invalidate_metadata
custom_cluster/test_concurrent_ddls.py::TestConcurrentDdls::test_local_catalog_ddls_with_invalidate_metadata_sync_ddl
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@212
PS17, Line 212: "
> flake8: E501 line too long (92 > 90 characters)
I agree with Michael comment that it is not worth to have dedicated option 'use_on_demand_metadata_mixed'.
https://gerrit.cloudera.org/c/21443/15/bin/start-impala-cluster.py#204
Please remove this.
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@469
PS17, Line 469: return catalogd_arg_list
Before returning, assert that there is only 1 'catalog_topic_mode' arg in catalogd_arg_list.
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@694
PS17, Line 694: return impalad_args
Before returning, assert that there is only 1 'use_local_catalog' arg in impalad_args.
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@1175
PS17, Line 1175: LOG.info("Starting Impala cluster with the following configuration:")
: LOG.info("Cluster size: %d", options.cluster_size)
Remove this. This is redundant with LOG in L1169.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 19:59:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Patch Set 17:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/21443/17/bin/start-impala-cluster.py@204
PS17, Line 204: parser.add_option("--use_on_demand_metadata", dest="use_on_demand_metadata"
> Please edit existing test to prove that this new options work. These are so
Actually, please disregard this request. It will just complicate CustomClusterTestSuite.with_args.
Lets just use this new arg for ad hoc usage.
--
To view, visit http://gerrit.cloudera.org:8080/21443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 20:15:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12869: Shorten argument list to enable local catalog mode
Posted by "Anshula Jain (Code Review)" <ge...@cloudera.org>.
Anshula Jain has abandoned this change. ( https://gerrit.cloudera.org/21443 )
Change subject: IMPALA-12869: Shorten argument list to enable local catalog mode
......................................................................
Abandoned
as recommended discarding this change
--
To view, visit https://gerrit.cloudera.org/21443
To unsubscribe, visit https://gerrit.cloudera.org/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iab5f3613b39a8473ba1f6ab7cb2634d87b808142
Gerrit-Change-Number: 21443
Gerrit-PatchSet: 17
Gerrit-Owner: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Anshula Jain <j_...@yahoo.in>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@gmail.com>