You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Shawn Jiang (JIRA)" <ji...@apache.org> on 2009/07/23 07:51:14 UTC
[jira] Created: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
i18n properties files should be converted to ascii at build time.
------------------------------------------------------------------
Key: GERONIMO-4763
URL: https://issues.apache.org/jira/browse/GERONIMO-4763
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: usability
Affects Versions: 2.1.5, 2.2
Reporter: Shawn Jiang
Assignee: Shawn Jiang
Priority: Minor
Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
{code}
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>native2ascii-maven-plugin</artifactId>
<version>1.0-alpha-1</version>
<configuration>
<dest>target/classes</dest>
<src>src/main/resources</src>
</configuration>
<executions>
<execution>
<id>native2ascii-utf8</id>
<goals>
<goal>native2ascii</goal>
</goals>
<configuration>
<encoding>UTF8</encoding>
<includes>
ConsoleResources_jp.properties,
ConsoleResources_zh*.properties
</includes>
</configuration>
</execution>
</executions>
</plugin>
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-4763.
----------------------------------
Resolution: Fixed
patch applied rev 802439, thanks shawn!
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Ogawa reopened GERONIMO-4763:
---------------------------------
Ivan,
English resource bundle files in the PlanCreator portlet aren't "*_en.properties". Please rename them.
Please open the following link:
https://svn.apache.org/repos/asf/geronimo/server/trunk/plugins/plancreator/plancreator-portlets/src/main/i18n-resources/
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_fix_inactive_profiles.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-4763) i18n properties files
should be converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736553#action_12736553 ]
Shawn Jiang edited comment on GERONIMO-4763 at 7/29/09 6:01 AM:
----------------------------------------------------------------
Clearing this comments because there's no problem with NON-SUN JDK at all.
was (Author: genspring):
Unfortunately, This native2ascii-maven-plugin depends on com.sun.tools.native2ascii.* classes in tools.jar of SUN JDK. NON-SUN JDKs(IBM or Bea, or others) does not have these native2ascii implementation classes.
As I know, geronimo is using SUN JDK as its build JDK. But for NON-SUN JDK users, As a workaround, he or she have to use the method described in
{noformat}
http://maven.apache.org/general.html#tools-jar-dependency
{noformat}
to add sun tools.jar as an dependency. I don't know if it's acceptable, please advise.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738231#action_12738231 ]
Jack Cai commented on GERONIMO-4763:
------------------------------------
AFAIK, there is no Harmony equivalent yet. A few JDK tools haven't been implemented in Harmony yet.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735979#action_12735979 ]
Ivan commented on GERONIMO-4763:
--------------------------------
If no objection, I would like to do this change to 2.2, it should make the i18n work more easilier.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737328#action_12737328 ]
David Jencks commented on GERONIMO-4763:
----------------------------------------
I have no objection to using the plugin, I was mostly wondering if a harmony component could be used in the native2ascii plugin to remove the dependency on sun vm code.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736553#action_12736553 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
Unfortunately, This native2ascii-maven-plugin depends on com.sun.tools.native2ascii.* classes in tools.jar of SUN JDK. NON-SUN JDKs(IBM or Bea, or others) does not have these native2ascii implementation classes.
As I know, geronimo is using SUN JDK as its build JDK. But for NON-SUN JDK users, As a workaround, he or she have to use the method described in
{noformat}
http://maven.apache.org/general.html#tools-jar-dependency
{noformat}
to add sun tools.jar as an dependency. I don't know if it's acceptable, please advise.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-4763) i18n properties files
should be converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735344#action_12735344 ]
Shawn Jiang edited comment on GERONIMO-4763 at 7/25/09 8:06 PM:
----------------------------------------------------------------
{noformat}
- everything is in ascii unicode escape sequences all the time (is this what we have now?)
{noformat}
yes, this is what we have. use \uXXXX ascii as the i18n resource storage format.
{noformat}
- everything is in utf-8 all the time (svn, checked out source code, any compiled property files
{noformat}
not exactly, we can make it because resource bundle only happy with \uXXXX escaped format.
- utf-8 in svn and checkout and unicode escape after compilation
{noformat}
This is what I'm going to do.
EOL of svn does not have any relationship with this i18n content encoding.
I've tested Eclipse, notepad, gedit, vim. They are all happy with UTF-8 i18n properties. I think if the editor support utf-8, there's no reason it can't read UTF-8 i18n native language properties.
As for the question why would we change to ascii during compilation?
The problem is with resource bundles. For resouce bundle, Properties files are always read as ISO-8859-1. As a result, To include Unicode characters in i18n properties file, we must use \uXXXX escapes(with native2ascii tool).
was (Author: genspring):
{noformat}
- everything is in ascii unicode escape sequences all the time (is this what we have now?)
{noformat}
yes
{noformat}
- everything is in utf-8 all the time (svn, checked out source code, any compiled property files
{noformat}
- utf-8 in svn and checkout and unicode escape after compilation
The problem is with resource bundles. For resouce bundle, Properties files are always read as ISO-8859-1. As a result, To include Unicode characters in i18n properties file, we must use \uXXXX escapes(with native2ascii tool).
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang reopened GERONIMO-4763:
-----------------------------------
Maven does not support multiple activated profiles at the same time.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739879#action_12739879 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
David,
Can you advise can we apply this patch even when there's no harmony native2ascii component ?
In my opinion, native2ascii is widely used in JAVA world. If we only use it only for build time. There's no big problem here. As for harmony + geronimo build, We can still workaround it by adding a external native2ascii dependency to pom file.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan resolved GERONIMO-4763.
----------------------------
Resolution: Fixed
Fix Version/s: 2.2
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang updated GERONIMO-4763:
----------------------------------
Attachment: G4763_fix_inactive_profiles.patch
Put the ibmjdk profile to pom.xml of plugins since we only depend on native2ascii plugin in there.
It workaround the limitation of maven that it does not support multiple active profiles in the *same* pom file.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_fix_inactive_profiles.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741214#action_12741214 ]
David Jencks commented on GERONIMO-4763:
----------------------------------------
The classes are the the classes.jar and the build worked fine before adding this dependency.
I suspect that having a profile with a pluginmanagerment section that only adds the dependency will work. I'm not sure how to active the profile depending on the jdk.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735987#action_12735987 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
Kan,
The reason why I just uploaded patch on trunk is that we are going to branch 2.2. I'll make a 2.1 patch soon.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736797#action_12736797 ]
David Jencks commented on GERONIMO-4763:
----------------------------------------
Will the native2ascii work with harmony? If not directly do they have an equivalent solution?
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741190#action_12741190 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
I don't have a Mac at hand. Can you verify if there's a jar in mac os x JDK that conatins "sun.tools.native2ascii.*" ?
If there's not, I don't think a simple profile can resolve this. Mac JDK user might need a copy of a jar that contains "sun.tools.native2ascii.*" to start the mac profile.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reopened GERONIMO-4763:
------------------------------------
This solution prevents building on mac os x where there is no tools.jar file at all.
I susupect we could solve this with profiles for different jdks.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741218#action_12741218 ]
Jack Cai commented on GERONIMO-4763:
------------------------------------
A profile can also be activated bt determing the OS. This might be useful to deal with Mac OS.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739924#action_12739924 ]
David Jencks commented on GERONIMO-4763:
----------------------------------------
I have no objections to the patch.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736622#action_12736622 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
Jack,
Thanks for your reminder, you are right. IBM JDK also has these classes. Actually I just tried to build the patched geronimo with IBM JDK. There's no problem !
There was a misleading JIRA on native2ascii maven plugin here: http://jira.codehaus.org/browse/MOJO-682 . I turned out that the reporter is using JRE instead of JDK when he is using the plugin. -_____-!
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan reassigned GERONIMO-4763:
------------------------------
Assignee: Ivan (was: Shawn Jiang)
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736570#action_12736570 ]
Jack Cai commented on GERONIMO-4763:
------------------------------------
I think it is "sun.tools.native2ascii.*". Most JDKs should contain these classes in their tools.jar.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12743087#action_12743087 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
I filed a JIRA against maven here:
http://jira.codehaus.org/browse/MNG-4300, Maven does not support multiple activted profiles in the same pom.xml at the same time.
Hopefully Maven can fix this in the next release.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_fix_inactive_profiles.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742727#action_12742727 ]
Ivan commented on GERONIMO-4763:
--------------------------------
I have tried the patch of Shawn on the Linux platform, seems it works.
David, could you please help to check it on you Mac machine ?
Thanks !
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_fix_inactive_profiles.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742674#action_12742674 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
Yes, there's no document on this. I just searched the google and found this:
http://n2.nabble.com/Activation-of-multiple-profiles-at-the-same-time-td2496510.html#none
It's definitely a defect of maven.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736961#action_12736961 ]
Kan Ogawa commented on GERONIMO-4763:
-------------------------------------
Lars,
When doing checkout and diff i18n properties from svn repository, it is a big merit to read them directly without native2ascii tool.
Also, if a simple translating work, translator doesn't need to always prepare jdk itself (including native2ascii) and it is possible to edit i18n properties easily and effectively on various editor (e.g. notepad, vim, and emacs, etc.).
So I voted here.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang updated GERONIMO-4763:
----------------------------------
Attachment: G4763_fix_IBM_SDK.patch
Here is the patch to fix the IBM SDK compilation problem. Thanks.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-4763.
----------------------------------
Resolution: Fixed
I added a profile activated by the tools.jar file that includes the dependency. rev 803287. We'll see if it works -- at least I think building on osx works.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor resolved GERONIMO-4763.
-----------------------------------
Resolution: Fixed
I renamed the PlanCreator resource bundles (2.2: 805860, trunk: 805859). Thanks for reporting this!
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_fix_inactive_profiles.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Ivan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739950#action_12739950 ]
Ivan commented on GERONIMO-4763:
--------------------------------
Commit the patch to trunk at rev 801552. Thanks !
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (GERONIMO-4763) i18n properties files
should be converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735344#action_12735344 ]
Shawn Jiang edited comment on GERONIMO-4763 at 7/25/09 8:10 PM:
----------------------------------------------------------------
{noformat}
- everything is in ascii unicode escape sequences all the time (is this what we have now?)
{noformat}
yes, this is what we have. use \uXXXX ascii as the i18n resource storage format.
{noformat}
- everything is in utf-8 all the time (svn, checked out source code, any compiled property files
{noformat}
not exactly, we can't use utf-8(except 8859-1 char) in compiled properties because resource bundle only happy with \uXXXX escaped format with 8859-1 charset.
{noformat}
- utf-8 in svn and checkout and unicode escape after compilation
{noformat}
This is what I'm going to do.EOL of svn does not have any relationship with this i18n content encoding. I've tested Eclipse, notepad, gedit, vim. They are all happy with UTF-8 i18n properties. I think if the editor support utf-8, there's no reason it can't read UTF-8 i18n native language properties.
As for the question "why would we change to ascii during compilation?"
The problem is with resource bundles. For resouce bundle, Properties files are always read as ISO-8859-1. As a result, To include Unicode characters in i18n properties file, we must use \uXXXX escapes(with native2ascii tool).
was (Author: genspring):
{noformat}
- everything is in ascii unicode escape sequences all the time (is this what we have now?)
{noformat}
yes, this is what we have. use \uXXXX ascii as the i18n resource storage format.
{noformat}
- everything is in utf-8 all the time (svn, checked out source code, any compiled property files
{noformat}
not exactly, we can make it because resource bundle only happy with \uXXXX escaped format.
- utf-8 in svn and checkout and unicode escape after compilation
{noformat}
This is what I'm going to do.
EOL of svn does not have any relationship with this i18n content encoding.
I've tested Eclipse, notepad, gedit, vim. They are all happy with UTF-8 i18n properties. I think if the editor support utf-8, there's no reason it can't read UTF-8 i18n native language properties.
As for the question why would we change to ascii during compilation?
The problem is with resource bundles. For resouce bundle, Properties files are always read as ISO-8859-1. As a result, To include Unicode characters in i18n properties file, we must use \uXXXX escapes(with native2ascii tool).
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734920#action_12734920 ]
David Jencks commented on GERONIMO-4763:
----------------------------------------
What are the options that will work here? I can think of a few but I don't know which will work:
-- everything is in ascii unicode escape sequences all the time (is this what we have now?)
-- everything is in utf-8 all the time (svn, checked out source code, any compiled property files
-- utf-8 in svn and checkout and unicode escape after compilation
The last two require that svn handle checkout and checkin of utf-8 files without problem on various line-ending systems. Has anyone verified that this would work? Also we might investigate what these property files would look like in common IDES such as idea, eclipse, emacs, vim.
Assuming utf-8 in svn and IDEs works ok, why would we change to ascii during compilation?
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Kan Ogawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735983#action_12735983 ]
Kan Ogawa commented on GERONIMO-4763:
-------------------------------------
Ivan,
In addition, is it possible to change this to 2.1?
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736963#action_12736963 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
Will the native2ascii work with harmony? If not directly do they have an equivalent solution?
--------------------------------------
I don't know, Harmony should have a bunch of build problems with Geronimo besides this. If Harmony does not have the equivalent solution. Maybe they should have a feature JIRA open to add this support.
Anyway, I agree that if we need to support building geronimo with Harmony, we can't apply the patch of this JIRA for now.
is it really neccessary to add additional build complexity?
-------------------------------------
As Kan said, It's really necessary for i18n translation contributors.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks closed GERONIMO-4763.
----------------------------------
Resolution: Fixed
Patcch applied rev 803916. Worked fine on my mac. very clever! thanks!
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_fix_inactive_profiles.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Gawor reopened GERONIMO-4763:
-----------------------------------
Trunk builds on IBM SDK are broken by this change: http://people.apache.org/builds/geronimo/server/binaries/trunk/20090807/build-0300.log
Looks like the native2ascii-maven-plugin-1.0-alpha-1 is missing a build profile for IBM SDK where it adds the tools.jar to its classpath (as it does for Sun JDKs). We need to fix the plugin or change our poms to directly use the Ant task and construct the classpath correctly.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742545#action_12742545 ]
David Jencks commented on GERONIMO-4763:
----------------------------------------
How do you know that maven doesn't support multiple activated profiles? this seems like a giant limitation and I couldn't find documentation saying this.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Rex Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734887#action_12734887 ]
Rex Wang commented on GERONIMO-4763:
------------------------------------
I like this:-)
-Rex
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Jack Cai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742272#action_12742272 ]
Jack Cai commented on GERONIMO-4763:
------------------------------------
I guess the jms-resource-providers.properties in console-base-portlets and activemq-portlets should remain in the "resources" folder instead of moving to i18n-resources.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Fix For: 2.2
>
> Attachments: G4763_fix_IBM_SDK.patch, G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shawn Jiang updated GERONIMO-4763:
----------------------------------
Attachment: G4763_mv_i18n_trunk.bat
G4763_trunk.patch
1, Please apply G4763_trunk.patch with trunk code firstly. You need to verify if the patched i18n file is UTF-8 encoding. Eg. If you are using TortoiseSVN on windows. Please make sure default UTF-8 patch option is on.
{noformat}
TortoiseMerge-->menu View --->settings--->general -->default to UTF-8 encoding.
{noformat}
2, Use G4763_mv_i18n_trunk.bat to svn mvn all needed i18n resource to i18n-resources.
Please replace the trunk path in the script to your local trunk path before running the script.
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735344#action_12735344 ]
Shawn Jiang commented on GERONIMO-4763:
---------------------------------------
{noformat}
- everything is in ascii unicode escape sequences all the time (is this what we have now?)
{noformat}
yes
{noformat}
- everything is in utf-8 all the time (svn, checked out source code, any compiled property files
{noformat}
- utf-8 in svn and checkout and unicode escape after compilation
The problem is with resource bundles. For resouce bundle, Properties files are always read as ISO-8859-1. As a result, To include Unicode characters in i18n properties file, we must use \uXXXX escapes(with native2ascii tool).
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Shawn Jiang
> Priority: Minor
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4763) i18n properties files should be
converted to ascii at build time.
Posted by "Lars Kühne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736827#action_12736827 ]
Lars Kühne commented on GERONIMO-4763:
--------------------------------------
There are Eclipse plugins like [eclipse-rbe|http://sourceforge.net/projects/eclipse-rbe/] that do the ascii conversion on the fly. Idea also supports this [out of the box|http://jira.xwiki.org/jira/browse/XWIKI-1056?focusedCommentId=13873&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_13873].
In light of these tools, is it really neccessary to add additional build complexity?
> i18n properties files should be converted to ascii at build time.
> ------------------------------------------------------------------
>
> Key: GERONIMO-4763
> URL: https://issues.apache.org/jira/browse/GERONIMO-4763
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.1.5, 2.2
> Reporter: Shawn Jiang
> Assignee: Ivan
> Priority: Minor
> Attachments: G4763_mv_i18n_trunk.bat, G4763_trunk.patch
>
>
> Current i18n properties files are stored in source code repo after they are converted to ascii from native offline. It's very hard to contribute new translations.
> We should keep native characters in source code while convert them to ascii at build time. maven plugin native2ascii-maven-plugin could be used here:
> {code}
> <plugin>
> <groupId>org.codehaus.mojo</groupId>
> <artifactId>native2ascii-maven-plugin</artifactId>
> <version>1.0-alpha-1</version>
> <configuration>
> <dest>target/classes</dest>
> <src>src/main/resources</src>
> </configuration>
> <executions>
> <execution>
> <id>native2ascii-utf8</id>
> <goals>
> <goal>native2ascii</goal>
> </goals>
> <configuration>
> <encoding>UTF8</encoding>
> <includes>
> ConsoleResources_jp.properties,
> ConsoleResources_zh*.properties
> </includes>
> </configuration>
> </execution>
> </executions>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.