You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/01 03:59:04 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #2225: Backport #2210: Make configureproxy idenpotent when invoked multiple times
JaroslavTulach opened a new pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225
Backporting #2210 to release 12.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2225: Make configureproxy idenpotent when invoked multiple times
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225#issuecomment-653394916
This is not a change in a module, but in the infrastructure build tasks. I am not able to build NetBeans behind our corporate proxy without it. I don't think there is a need to increase any spec versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2225: Make configureproxy idenpotent when invoked multiple times
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225#discussion_r448187555
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ConfigureProxy.java
##########
@@ -84,51 +84,21 @@ public void execute() throws BuildException {
static URLConnection openConnection(Task task, final URL url, URI[] connectedVia) throws IOException {
final URLConnection[] conn = { null };
final List<Exception> errs = new CopyOnWriteArrayList<>();
+ final StringBuilder msgs = new StringBuilder();
Review comment:
Done in 40584ecfeb52cfd7f8f5bc619ad97ad968303819 - if approved, I also merge it to `master`.
Btw. the code was ready for being used from multiple threads - see all the `msgs.append("x' + a + " y " + b + " z" + c)` concatentations that are done in single thread and only then placed into the `msgs` object. Why did I not used `StringBuffer` then? I know I wanted...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2225: Make configureproxy idenpotent when invoked multiple times
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225#issuecomment-652376040
Thanks for the review. I merged the changes into master as 58bd5a3 - I'll wait with merging this PR into `release120` branch for Laszló's approval. Or feel free to merge it yourself @lkishalmi!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2225: Make configureproxy idenpotent when invoked multiple times
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225#discussion_r448182699
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ConfigureProxy.java
##########
@@ -84,51 +84,21 @@ public void execute() throws BuildException {
static URLConnection openConnection(Task task, final URL url, URI[] connectedVia) throws IOException {
final URLConnection[] conn = { null };
final List<Exception> errs = new CopyOnWriteArrayList<>();
+ final StringBuilder msgs = new StringBuilder();
Review comment:
E.g. it should be `StringBuffer`, not builder. Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2225: Make configureproxy idenpotent when invoked multiple times
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225#discussion_r448127938
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ConfigureProxy.java
##########
@@ -84,51 +84,21 @@ public void execute() throws BuildException {
static URLConnection openConnection(Task task, final URL url, URI[] connectedVia) throws IOException {
final URLConnection[] conn = { null };
final List<Exception> errs = new CopyOnWriteArrayList<>();
+ final StringBuilder msgs = new StringBuilder();
Review comment:
Isn't `msgs` operated from different threads ? Noticed only now :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2225: Make configureproxy idenpotent when invoked multiple times
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2225:
URL: https://github.com/apache/netbeans/pull/2225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists