You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by wido <gi...@git.apache.org> on 2016/04/12 11:17:45 UTC
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1488
agent: Enable IPv6 connectivity for KVM Agent to Management Server
IPv4 is still preferred, so if the hostname of the Management Server
returns a A and AAAA-record the Agent will still connect to the
server over IPv4.
This situation will however allow to use a hostname which only has
a AAAA-record. In that case the Agent will connect to the Management
Server over IPv6.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wido/cloudstack agent-ipv6-enable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1488
----
commit 16651feca02798f00a55f123c3e119a981576f53
Author: Wido den Hollander <wi...@widodh.nl>
Date: 2016-04-12T09:15:09Z
agent: Enable IPv6 connectivity for KVM Agent to Management Server
IPv4 is still preferred, so if the hostname of the Management Server
returns a A and AAAA-record the Agent will still connect to the
server over IPv4.
This situation will however allow to use a hostname which only has
a AAAA-record. In that case the Agent will connect to the Management
Server over IPv6.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-216289908
Need to run CI against this one to verify...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-217773917
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 4h 33m 33s
```
**Summary of the problem(s):**
```
FAIL: Test redundant router internals
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/git/cs2/cloudstack/test/integration/smoke/test_routers_network_ops.py", line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be successful!
----------------------------------------------------------------------
Additional details in: /tmp/MarvinLogs/test_network_ZPKO7W/results.txt
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_23_46_2X8SE4/runinfo.txt)
**`/tmp/MarvinLogs/test_network_ZPKO7W:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_network_ZPKO7W/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_network_ZPKO7W/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_network_ZPKO7W/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_6GSXPB:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_vpc_routers_6GSXPB/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_vpc_routers_6GSXPB/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1488/tmp/MarvinLogs/test_vpc_routers_6GSXPB/runinfo.txt)
Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-217873032
We have the required code review and tests, I will add this to my merge queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-216228181
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208821534
after a long search, I can find no syntax errors. LGTM based on code and report.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-214732036
Thanks @DaanHoogland for the LGTM.
One more and we can merge this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208811822
At PCextreme we have 'ipv6disabled' set to 'false' on our hypervisors and they are all connected over IPv6.
Connections we see open from the Management Server to the Agent:
<pre>root@man:~# netstat -nap|grep ESTABLISHED|grep 8250
...
tcp6 0 0 2a00:f10:ff02::825:8250 2a00:f10:10a:XX:XX:58704 ESTABLISHED 3626/jsvc.exec
...
root@man:~#</pre>
Our testing has been done in the real world. This change is just so that a IPv6-only hostname for a Management Server works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-208819704
@wido Great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---