[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16083: [improvement](memory) load support overcommit memory

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #16083:
URL: https://github.com/apache/doris/pull/16083#discussion_r1080690283


##########
be/src/runtime/memory/mem_tracker_limiter.h:
##########
@@ -105,7 +105,8 @@ class MemTrackerLimiter final : public MemTracker {
     int64_t limit() const { return _limit; }
     bool limit_exceeded() const { return _limit >= 0 && _limit < consumption(); }
 
-    Status check_limit(int64_t bytes);
+    Status check_limit(int64_t bytes = 0);
+    bool is_overcommit_tracker() { return type() == Type::QUERY || type() == Type::LOAD; }

Review Comment:
   warning: method 'is_overcommit_tracker' can be made const [readability-make-member-function-const]
   
   ```suggestion
       bool is_overcommit_tracker() const { return type() == Type::QUERY || type() == Type::LOAD; }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org