You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/14 08:45:07 UTC
[GitHub] [superset] cemremengu opened a new pull request, #19713: refactor(timezone): remove names from selector
cemremengu opened a new pull request, #19713:
URL: https://github.com/apache/superset/pull/19713
### SUMMARY
Although showing names is a very nice feature, not showing all of them creates confusion.
For example, for GMT +03:00 our users are expecting `Europe/Istanbul` but instead are seeing `Antartica/Syowa` as the name.
I believe showing just the timezone offset is enough information when deduplicating zones.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu closed pull request #19713: refactor(frontend): remove names from timezone selector
Posted by GitBox <gi...@apache.org>.
cemremengu closed pull request #19713: refactor(frontend): remove names from timezone selector
URL: https://github.com/apache/superset/pull/19713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cemremengu commented on pull request #19713: refactor(frontend): remove names from timezone selector
Posted by GitBox <gi...@apache.org>.
cemremengu commented on PR #19713:
URL: https://github.com/apache/superset/pull/19713#issuecomment-1099092065
I think I am making a mistake here, need to reevaluate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org