You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2018/01/11 01:07:34 UTC
[royale-asjs] branch develop updated: remove
className="DynamicGridColumn" to fix compilation of DataGridExample
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 1d31f1a remove className="DynamicGridColumn" to fix compilation of DataGridExample
1d31f1a is described below
commit 1d31f1a6fe0b303b0a060c3f419798db568b6d9e
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu Jan 11 02:07:30 2018 +0100
remove className="DynamicGridColumn" to fix compilation of DataGridExample
---
examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml b/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
index bf530b7..a5316aa 100644
--- a/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
+++ b/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
@@ -106,9 +106,9 @@ limitations under the License.
destinationPropertyName="dataProvider" />
</js:beads>
<js:columns>
- <js:DataGridColumn label="Image" dataField="image" columnWidth="100" itemRenderer="products.ProductItemRenderer" className="DynamicGridColumn" />
- <js:DataGridColumn label="Title" dataField="title" columnWidth="200" className="DynamicGridColumn" />
- <js:DataGridColumn label="Sales" dataField="sales" columnWidth="100" className="DynamicGridColumn" />
+ <js:DataGridColumn label="Image" dataField="image" columnWidth="100" itemRenderer="products.ProductItemRenderer" />
+ <js:DataGridColumn label="Title" dataField="title" columnWidth="200" />
+ <js:DataGridColumn label="Sales" dataField="sales" columnWidth="100" />
</js:columns>
</js:DataGrid>
--
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <co...@royale.apache.org>'].
Re: [royale-asjs] branch develop updated: remove className="DynamicGridColumn"
to fix compilation of DataGridExample
Posted by Carlos Rovira <ca...@apache.org>.
Hi Piotr,
just reverse the commit right now
thanks
2018-01-11 5:16 GMT+01:00 Piotr Zarzycki <pi...@gmail.com>:
> Carlos,
>
> You shouldn't do this. This is problem with compilation introduced when
> Alex prepared first RC. Please get back with that code before RC2 in order
> to have it reproducible. It is something messed up with versions in pom.
>
> Thanks, Piotr
>
> On Thu, Jan 11, 2018, 02:07 <ca...@apache.org> wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > carlosrovira pushed a commit to branch develop
> > in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >
> >
> > The following commit(s) were added to refs/heads/develop by this push:
> > new 1d31f1a remove className="DynamicGridColumn" to fix compilation
> > of DataGridExample
> > 1d31f1a is described below
> >
> > commit 1d31f1a6fe0b303b0a060c3f419798db568b6d9e
> > Author: Carlos Rovira <ca...@apache.org>
> > AuthorDate: Thu Jan 11 02:07:30 2018 +0100
> >
> > remove className="DynamicGridColumn" to fix compilation of
> > DataGridExample
> > ---
> > examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml | 6
> > +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> > b/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> > index bf530b7..a5316aa 100644
> > --- a/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> > +++ b/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> > @@ -106,9 +106,9 @@ limitations under the License.
> > destinationPropertyName="dataProvider"
> />
> > </js:beads>
> > <js:columns>
> > - <js:DataGridColumn label="Image"
> dataField="image"
> > columnWidth="100" itemRenderer="products.ProductItemRenderer"
> > className="DynamicGridColumn" />
> > - <js:DataGridColumn label="Title"
> dataField="title"
> > columnWidth="200" className="DynamicGridColumn" />
> > - <js:DataGridColumn label="Sales"
> dataField="sales"
> > columnWidth="100" className="DynamicGridColumn" />
> > + <js:DataGridColumn label="Image"
> dataField="image"
> > columnWidth="100" itemRenderer="products.ProductItemRenderer" />
> > + <js:DataGridColumn label="Title"
> dataField="title"
> > columnWidth="200" />
> > + <js:DataGridColumn label="Sales"
> dataField="sales"
> > columnWidth="100" />
> > </js:columns>
> > </js:DataGrid>
> >
> >
> > --
> > To stop receiving notification emails like this one, please contact
> > ['"commits@royale.apache.org" <co...@royale.apache.org>'].
> >
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [royale-asjs] branch develop updated: remove className="DynamicGridColumn"
to fix compilation of DataGridExample
Posted by Piotr Zarzycki <pi...@gmail.com>.
Carlos,
You shouldn't do this. This is problem with compilation introduced when
Alex prepared first RC. Please get back with that code before RC2 in order
to have it reproducible. It is something messed up with versions in pom.
Thanks, Piotr
On Thu, Jan 11, 2018, 02:07 <ca...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> carlosrovira pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 1d31f1a remove className="DynamicGridColumn" to fix compilation
> of DataGridExample
> 1d31f1a is described below
>
> commit 1d31f1a6fe0b303b0a060c3f419798db568b6d9e
> Author: Carlos Rovira <ca...@apache.org>
> AuthorDate: Thu Jan 11 02:07:30 2018 +0100
>
> remove className="DynamicGridColumn" to fix compilation of
> DataGridExample
> ---
> examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml | 6
> +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> b/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> index bf530b7..a5316aa 100644
> --- a/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> +++ b/examples/royale/DataGridExample/src/main/royale/MyInitialView.mxml
> @@ -106,9 +106,9 @@ limitations under the License.
> destinationPropertyName="dataProvider" />
> </js:beads>
> <js:columns>
> - <js:DataGridColumn label="Image" dataField="image"
> columnWidth="100" itemRenderer="products.ProductItemRenderer"
> className="DynamicGridColumn" />
> - <js:DataGridColumn label="Title" dataField="title"
> columnWidth="200" className="DynamicGridColumn" />
> - <js:DataGridColumn label="Sales" dataField="sales"
> columnWidth="100" className="DynamicGridColumn" />
> + <js:DataGridColumn label="Image" dataField="image"
> columnWidth="100" itemRenderer="products.ProductItemRenderer" />
> + <js:DataGridColumn label="Title" dataField="title"
> columnWidth="200" />
> + <js:DataGridColumn label="Sales" dataField="sales"
> columnWidth="100" />
> </js:columns>
> </js:DataGrid>
>
>
> --
> To stop receiving notification emails like this one, please contact
> ['"commits@royale.apache.org" <co...@royale.apache.org>'].
>