You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/08/02 16:18:19 UTC
[GitHub] [lucene-solr] diegoceccarelli commented on issue #300: SOLR-11831:
Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)
diegoceccarelli commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-517760941
@cpoerschke I rebased on top of the current master, please note that:
1. I had to change the returned type of `serializeOneSearchGroup` from `Object[]` to `Object` because `SkipSecondStepSearchResultResultTransformer` will return a `NamedList`
2. I moved the check on `QueryComponent` cfd22cd (SOLR-12249) - ( when group.format=grouped then, validate group.offset) into `GroupingSpecification::validate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org