You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 04:03:03 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
xinyiZzz opened a new pull request, #14871:
URL: https://github.com/apache/doris/pull/14871
# Proposed changes
Issue Number: close #xxx
## Problem summary
https://github.com/jemalloc/jemalloc/releases
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1340466072
Is there api change of JeMalloc in new version.
If yes, we need to create a tag for docker build env for the old versin.
And please update the thirdparty in a single PR, and also modify:
```
thirdparty/CHANGELOG.md
dist/LICENSE-dist.txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1340343087
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3635735380") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In thirdparty/download-thirdparty.sh line 339:
if [[ "${JEMALLOC_SOURCE}" = "jemalloc-5.2.1" ]]; then
^----------------^ SC2154 (warning): JEMALLOC_SOURCE is referenced but not assigned.
For more information:
https://www.shellcheck.net/wiki/SC2154 -- JEMALLOC_SOURCE is referenced but...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' found no issues.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1340543368
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1340369943
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.35 seconds
load time: 432 seconds
storage size: 17123356141 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207045046_clickbench_pr_59078.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1340344831
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #14871:
URL: https://github.com/apache/doris/pull/14871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1434734423
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14871: [enhancement](third-party) Upgrade JEMalloc version from 5.2.1 to 5.3.0
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14871:
URL: https://github.com/apache/doris/pull/14871#issuecomment-1435984880
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org