You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/08 17:32:20 UTC

[jira] [Work logged] (TS-4503) MachineFatal should shutdown without cleanup

     [ https://issues.apache.org/jira/browse/TS-4503?focusedWorklogId=28463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28463 ]

ASF GitHub Bot logged work on TS-4503:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Sep/16 17:32
            Start Date: 08/Sep/16 17:32
    Worklog Time Spent: 10m 
      Work Description: GitHub user persiaAziz opened a pull request:

    https://github.com/apache/trafficserver/pull/991

    TS-4503: Remove the class ErrorClass and all it's child classes 

    TS-4503: Remove the class ErrorClass and all it's child classes …(for e.g., machinFatal, processFatal...).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/persiaAziz/trafficserver TS-4503

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #991
    
----
commit 0c1e43f75cca06c5b19df476d505206c7e070801
Author: Persia Aziz <pe...@yahoo-inc.com>
Date:   2016-09-07T22:41:07Z

    TS-4503: Remove the class ErrorClass and all it's child classes (for e.g., machinFatal, processFatal...)

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 28463)
            Time Spent: 10m
    Remaining Estimate: 0h

> MachineFatal should shutdown without cleanup
> --------------------------------------------
>
>                 Key: TS-4503
>                 URL: https://issues.apache.org/jira/browse/TS-4503
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Susan Hinrichs
>            Assignee: Syeda Persia Aziz
>             Fix For: 7.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When MachineFatalClass::raise() is called, it prints a message to the log and then calls exit.  exit causes memory cleanup to be called.  But if we are in such bad state that MachineFatal is called, it is quite likely that memory is messed up.
> We saw a crash where MachineFatal is called in thread 84.  This stack has the real error.  But the stack that got reported was on thread 1 in class destructor logic.  It would have been better if ATS failed immediately and the stack on thread 84 was reported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)