[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3088: adds tablet id to compaction configurer and selector

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #3088:
URL: https://github.com/apache/accumulo/pull/3088#discussion_r1027114511


##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactionConfigurer.java:
##########
@@ -50,6 +51,12 @@ public interface InitParameters {
   public interface InputParameters {
     TableId getTableId();
 
+    /**
+     * @return the id of the tablet being compacted
+     * @since 2.1.1
+     */
+    TabletId getTabletId();
+

Review Comment:
   This is an API addition. It shouldn't be added in a patch release, according to our semver rules.



##########
core/src/main/java/org/apache/accumulo/core/client/admin/compaction/CompactionSelector.java:
##########
@@ -61,6 +62,12 @@ Collection<Summary> getSummaries(Collection<CompactableFile> files,
 
     TableId getTableId();
 
+    /**
+     * @return the tablet id of the tablet being compacted
+     * @since 2.1.1
+     */
+    TabletId getTabletId();
+

Review Comment:
   Also public API. So, same comment here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org