[jira] [Commented] (SUREFIRE-2177) Favor junit-bom instead of single JUnit 5 versions

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730852#comment-17730852 ] 

ASF GitHub Bot commented on SUREFIRE-2177:
------------------------------------------

scordio opened a new pull request, #663:
URL: https://github.com/apache/maven-surefire/pull/663

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   




> Favor junit-bom instead of single JUnit 5 versions
> --------------------------------------------------
>
>                 Key: SUREFIRE-2177
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2177
>             Project: Maven Surefire
>          Issue Type: Dependency upgrade
>          Components: JUnit 5.x support
>    Affects Versions: 3.1.2
>            Reporter: Stefano Cordio
>            Priority: Minor
>              Labels: pull-request-available
>
> I have noticed from [95e8e95e|https://github.com/apache/maven-surefire/commit/95e8e95ee02ee0e12af70850440bd3d4c053d5db] that the Surefire project declares JUnit dependency versions separately. That commit upgraded the junit-jupiter dependencies to 5.9.3 and the junit-platform dependency to 1.9.2. However, I assume the latter should have been [1.9.3|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-platform] to stay in line with the [junit-jupiter version|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-jupiter].
> If keeping the junit-platform version behind is not on purpose, I propose to use instead the [junit-bom|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-bom] which would coordinate versioning of all the related JUnit modules.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)