[GitHub] [brooklyn-ui] algairim commented on a change in pull request #237: Switch relationships with path and label selector rather than group selector

[GitBox <gi...@apache.org>]

algairim commented on a change in pull request #237:
URL: https://github.com/apache/brooklyn-ui/pull/237#discussion_r662158999



##########
File path: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
##########
@@ -93,8 +93,8 @@ function BlueprintService($log, $q, $sce, paletteApi, iconGenerator, dslService,
                     source: entity,
                     target: relation.entity,
                     label: relation.name,
-                    pathSelector: 'relation', // the CSS class for path
-                    labelSelector: 'relation-label', // the CSS class for label
+                    pathSelector: 'relation-selector', // the CSS class for path
+                    labelSelector: 'relation-selector', // the CSS class for label

Review comment:
       Yes, selectors are the same for arcs and labels for Brooklyn relationships, however, they are can be different in the downstream versions where selecting of label and arc can be managed differently.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org