[GitHub] [geode] kirklund commented on a change in pull request #6440: DRAFT: Add New (Optional) Non-Differential Quorum Algorithm

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #6440:
URL: https://github.com/apache/geode/pull/6440#discussion_r694212898



##########
File path: geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
##########
@@ -104,7 +104,7 @@ public void before() {
   @Test
   public void testGetAttributeNames() {
     String[] attNames = AbstractDistributionConfig._getAttNames();
-    assertThat(attNames.length).isEqualTo(169);
+    assertThat(attNames.length).isEqualTo(170);

Review comment:
       This syntax provides better failure messages:
   ```
   assertThat(attNames).hasSize(170);
   ```
   I'd go ahead and convert the test to use only AssertJ. There's an IntelliJ plugin that can automate this but it's not very smart, I usually end up having to touch up anything involving collections, arrays, or messages.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org