You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2016/05/21 22:18:44 UTC

[GitHub] spark pull request: [SPARK-14554][SQL] disable whole stage codegen...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12322#discussion_r64141139
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala ---
    @@ -620,6 +620,12 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
         val df = streaming.join(static, Seq("b"))
         assert(df.isStreaming, "streaming Dataset returned false for 'isStreaming'.")
       }
    +
    +  test("SPARK-14554: Dataset.map may generate wrong java code for wide table") {
    +    val wideDF = sqlContext.range(10).select(Seq.tabulate(1000) {i => ('id + i).as(s"c$i")} : _*)
    +    // Make sure the generated code for this plan can compile and execute.
    +    wideDF.map(_.getLong(0)).collect()
    --- End diff --
    
    Do you know why this test case is super slow? It took more than 5 minutes to finish it. Is this expected?  
    
    ```
    - SPARK-14554: Dataset.map may generate wrong java code for wide table (5 minutes, 20 seconds)
    ```
    
    See the link: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59079/consoleFull


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org