You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/12/01 16:13:37 UTC

[PR] Bump the minimum Seata Client version for Seata AT integration to 2.2.0 [shardingsphere]

linghengqian opened a new pull request, #33872:
URL: https://github.com/apache/shardingsphere/pull/33872

   For #29052.
   
   Changes proposed in this pull request:
     - Bump the minimum Seata Client version for Seata AT integration to 2.2.0. **We finally started to get rid of the frequent warnings in CI logs about Alibaba Druid 1.2.7 being incompatible with JDK 23.** See https://github.com/apache/incubator-seata/pull/6523 . Also for #33791 .
   ```shell
   The POM for com.alibaba:druid:jar:1.2.7 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
   ```
     - `org.apache.seata.core.rpc.netty.v1.ProtocolV1Decoder` and `org.apache.seata.core.rpc.netty.v1.ProtocolV1Encoder` have been renamed in https://github.com/apache/incubator-seata/pull/6226 
     - **Due to https://github.com/apache/incubator-seata/pull/6661 , `client.rm.tableMetaCheckEnable` is now `true`, which completely breaks the logic of creating and destroying Seata Client in unit tests.** This needs to be investigated on the Seata side.
     - According to the opinions of the third-party article https://www.yuque.com/linghengqian/meve2v/es8d3a8a18odao7x , I started to reconstruct the Seata integration documentation on a large scale.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   - [x] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump the minimum Seata Client version for Seata AT integration to 2.2.0 [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #33872:
URL: https://github.com/apache/shardingsphere/pull/33872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Bump the minimum Seata Client version for Seata AT integration to 2.2.0 [shardingsphere]

Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on code in PR #33872:
URL: https://github.com/apache/shardingsphere/pull/33872#discussion_r1866061636


##########
test/native/src/test/resources/seata-script-client-conf-file.conf:
##########
@@ -20,3 +20,9 @@
 service {
     vgroupMapping.default_tx_group = "default"
 }
+# TODO This is not a reasonable configuration, just affected by https://github.com/apache/incubator-seata/pull/6661. Pending investigation.
+client {
+    rm {
+        tableMetaCheckEnable = "false"
+    }
+}

Review Comment:
   - I have opened https://github.com/apache/incubator-seata/issues/7042 . I don't believe this is sensible default behavior for Seata Client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org