You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/24 12:10:01 UTC
[GitHub] [hbase] Apache-HBase commented on pull request #2138: HBASE-20717 Implement CCSMap - a better concurrent map with compacted data structure
Apache-HBase commented on pull request #2138:
URL: https://github.com/apache/hbase/pull/2138#issuecomment-663507934
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 8m 0s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 3 new or modified test files. |
||| _ ccsmap Compile Tests _ |
| +0 :ok: | mvndep | 2m 25s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 4s | ccsmap passed |
| +1 :green_heart: | compile | 1m 2s | ccsmap passed with JDK v1.8.0_262 |
| +1 :green_heart: | compile | 1m 12s | ccsmap passed with JDK v1.7.0_272 |
| +1 :green_heart: | checkstyle | 2m 12s | ccsmap passed |
| +1 :green_heart: | shadedjars | 3m 3s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 59s | ccsmap passed with JDK v1.8.0_262 |
| +1 :green_heart: | javadoc | 1m 2s | ccsmap passed with JDK v1.7.0_272 |
| +0 :ok: | spotbugs | 2m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 0s | ccsmap passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 53s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed with JDK v1.8.0_262 |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 10s | the patch passed with JDK v1.7.0_272 |
| +1 :green_heart: | javac | 1m 10s | the patch passed |
| -1 :x: | checkstyle | 0m 30s | hbase-common: The patch generated 1 new + 27 unchanged - 0 fixed = 28 total (was 27) |
| -1 :x: | checkstyle | 1m 35s | hbase-server: The patch generated 154 new + 0 unchanged - 0 fixed = 154 total (was 0) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 49s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 6m 21s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. |
| -1 :x: | javadoc | 0m 33s | hbase-server-jdk1.8.0_262 with JDK v1.8.0_262 generated 11 new + 8 unchanged - 0 fixed = 19 total (was 8) |
| -1 :x: | javadoc | 0m 41s | hbase-server-jdk1.7.0_272 with JDK v1.7.0_272 generated 40 new + 8 unchanged - 0 fixed = 48 total (was 8) |
| -1 :x: | findbugs | 2m 57s | hbase-server generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 40s | hbase-common in the patch passed. |
| -1 :x: | unit | 33m 54s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 94m 46s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-server |
| | Class org.apache.hadoop.hbase.ccsmap.CompactedConcurrentSkipListMap implements Cloneable but does not define or use clone method At CompactedConcurrentSkipListMap.java:does not define or use clone method At CompactedConcurrentSkipListMap.java:[lines 45-2610] |
| | Class org.apache.hadoop.hbase.ccsmap.CompactedConcurrentSkipListMap defines non-transient non-serializable instance field settings In CompactedConcurrentSkipListMap.java:instance field settings In CompactedConcurrentSkipListMap.java |
| | Class org.apache.hadoop.hbase.ccsmap.CompactedConcurrentSkipListMap defines non-transient non-serializable instance field typeHelper In CompactedConcurrentSkipListMap.java:instance field typeHelper In CompactedConcurrentSkipListMap.java |
| | The field org.apache.hadoop.hbase.ccsmap.CompactedConcurrentSkipListMap.randomSeed is transient but isn't set by deserialization In CompactedConcurrentSkipListMap.java:but isn't set by deserialization In CompactedConcurrentSkipListMap.java |
| | Class org.apache.hadoop.hbase.ccsmap.CompactedConcurrentSkipListMap$SubMap implements Cloneable but does not define or use clone method At CompactedConcurrentSkipListMap.java:does not define or use clone method At CompactedConcurrentSkipListMap.java:[lines 1979-2484] |
| | Class org.apache.hadoop.hbase.ccsmap.CompactedConcurrentSkipListSet implements Cloneable but does not define or use clone method At CompactedConcurrentSkipListSet.java:does not define or use clone method At CompactedConcurrentSkipListSet.java:[lines 37-135] |
| | Unread field:CompactedConcurrentSkipListMap.java:[line 143] |
| | Unread field:CompactedConcurrentSkipListMap.java:[line 151] |
| | org.apache.hadoop.hbase.ccsmap.OnPageKeyValue doesn't override org.apache.hadoop.hbase.KeyValue.equals(Object) At OnPageKeyValue.java:At OnPageKeyValue.java:[line 1] |
| Failed junit tests | hadoop.hbase.ccsmap.TestCompactedTypeHelper |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/2138 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e5a1002993d1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2138/out/precommit/personality/provided.sh |
| git revision | ccsmap / 527e4a6 |
| Default Java | 1.7.0_272 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/diff-checkstyle-hbase-common.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/diff-checkstyle-hbase-server.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.8.0_262.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/diff-javadoc-javadoc-hbase-server-jdk1.7.0_272.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/new-findbugs-hbase-server.html |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/testReport/ |
| Max. process+thread count | 765 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2138/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org