You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/01 10:28:33 UTC

[GitHub] [incubator-shardingsphere] kimmking opened a new pull request #5038: extract MetaDataInitializedLogicSchema

kimmking opened a new pull request #5038: extract MetaDataInitializedLogicSchema
URL: https://github.com/apache/incubator-shardingsphere/pull/5038
 
 
   
   Changes proposed in this pull request:
   - extract MetaDataInitializedLogicSchema
   - avoid redundant load for shardingSchema
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5038: extract MetaDataInitializedLogicSchema

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5038: extract MetaDataInitializedLogicSchema
URL: https://github.com/apache/incubator-shardingsphere/pull/5038#issuecomment-607181690
 
 
   ## Pull Request Test Coverage Report for [Build 10769](https://coveralls.io/builds/29765743)
   
   * **1** of **43**   **(2.33%)**  changed or added relevant lines in **4** files are covered.
   * **5** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **57.16%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/MetaDataInitializedLogicSchema.java](https://coveralls.io/builds/29765743/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FMetaDataInitializedLogicSchema.java#L42) | 0 | 9 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29765743/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L85) | 0 | 16 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29765743/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L83) | 0 | 17 | 0.0%
   <!-- | **Total:** | **1** | **43** | **2.33%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29765743/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L89) | 1 | 0% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29765743/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L81) | 2 | 0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29765743/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L51) | 2 | 0% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29765743/badge)](https://coveralls.io/builds/29765743) |
   | :-- | --: |
   | Change from base [Build 10764](https://coveralls.io/builds/29759718): |  -0.02% |
   | Covered Lines: | 11667 |
   | Relevant Lines: | 20411 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5038: extract MetaDataInitializedLogicSchema

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5038: extract MetaDataInitializedLogicSchema
URL: https://github.com/apache/incubator-shardingsphere/pull/5038#issuecomment-607181690
 
 
   ## Pull Request Test Coverage Report for [Build 2317](https://coveralls.io/builds/29765836)
   
   * **1** of **43**   **(2.33%)**  changed or added relevant lines in **4** files are covered.
   * **7** unchanged lines in **4** files lost coverage.
   * Overall coverage increased (+**0.06%**) to **57.239%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/MetaDataInitializedLogicSchema.java](https://coveralls.io/builds/29765836/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FMetaDataInitializedLogicSchema.java#L42) | 0 | 9 | 0.0%
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29765836/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L85) | 0 | 16 | 0.0%
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29765836/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L83) | 0 | 17 | 0.0%
   <!-- | **Total:** | **1** | **43** | **2.33%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java](https://coveralls.io/builds/29765836/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2Fimpl%2FShardingSchema.java#L89) | 1 | 0% |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java](https://coveralls.io/builds/29765836/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fmetadata%2FShardingMetaDataLoader.java#L81) | 2 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29765836/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29765836/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L51) | 2 | 0% |
   <!-- | **Total:** | **7** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29765836/badge)](https://coveralls.io/builds/29765836) |
   | :-- | --: |
   | Change from base [Build 10764](https://coveralls.io/builds/29759718): |  0.06% |
   | Covered Lines: | 11683 |
   | Relevant Lines: | 20411 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5038: extract MetaDataInitializedLogicSchema

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5038: extract MetaDataInitializedLogicSchema
URL: https://github.com/apache/incubator-shardingsphere/pull/5038
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services