[GitHub] [qpid-proton] jdanekrh commented on issue #200: PROTON-2126 Fix Appveyor CI build

[GitBox <gi...@apache.org>]

jdanekrh commented on issue #200: PROTON-2126 Fix Appveyor CI build
URL: https://github.com/apache/qpid-proton/pull/200#issuecomment-549757732
 
 
   What I thought was important in this PR was to run pip using `"%PYTHON% -m pip install`, because that ensures the pip used corresponds to version of python being used. Appveyor VMs have 5+ versions of python installed at the same time, 32bit and 64bit variants. Not doing this was causing the original appveyor issue. That got merged.
   
   When you install the wheel package, or when you use python venv which automatically brings in wheel package, then the setup.py needs also updating. And this got merged also.
   
   I also thought that it is a good idea to drop the --user flag from pip invocation, since 1) test runs on throwaway VM 2) appveyor files I examined did not bother with it 3) one less flag to worry about.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org