You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/13 12:15:02 UTC
[GitHub] [cloudstack] ravening opened a new pull request #3803: Bug fix :
set restart_required to 0 after restarting network
ravening opened a new pull request #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803
## Description
<!--- Describe your changes in detail -->
After restarting the network with or without cleanup option, the ```restart_required``` field in ```networks``` table should be reset to 0
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1 . Check if the ```restart_required``` field in the ```networks``` table is 1 or not. If not you can set it to 1
2 . Restart the network with or without cleanup option.
3 . The ```restart_required``` field in the ```networks``` table should be reset to 0 once the network restarts successfully.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579104793
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-581916369
@ravening will this also fix all networks of the VPC when you restart VPC (not network) with cleanup?
cc/ @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579682049
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579978833
<b>Trillian test result (tid-839)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32316 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3803-t839-kvm-centos7.zip
Smoke tests completed. 78 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579732028
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579731716
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-578155897
wow @weizhouapache that is from oct 2014. I'm pretty sure some context has changed since then. for instance the zero downtime restart efforts. I don't think that change is relevant to still consider in this fix. preventing setting restart required to false just after setting it to true. probably it isn't needed any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-581936011
@andrijapanicsb in my testing, no...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579682115
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579090624
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579090740
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-581914872
ok, @andrijapanicsb , cherry-picking this on 4.13, as it won't hurt others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] andrijapanicsb commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-580723144
@DaanHoogland this fixes one of our internal issues. Thx @ravening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-579699675
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ravening opened a new pull request #3803: Bug fix :
set restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
ravening opened a new pull request #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803
## Description
<!--- Describe your changes in detail -->
After restarting the network with or without cleanup option, the ```restart_required``` field in ```networks``` table should be reset to 0
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1 . Check if the ```restart_required``` field in the ```networks``` table is 1 or not. If not you can set it to 1
2 . Restart the network with or without cleanup option.
3 . The ```restart_required``` field in the ```networks``` table should be reset to 0 once the network restarts successfully.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3803: Bug fix : set
restart_required to 0 after restarting network
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3803: Bug fix : set restart_required to 0 after restarting network
URL: https://github.com/apache/cloudstack/pull/3803#issuecomment-578063136
@DaanHoogland
when restart a network (shared/isolated) without cleanup, "Restart Required" will be "Yes" after it. This seems to be a regression issue of your commit 8218ce0fe243d85d0f4cb6280d2310a81c8e99de
Even if we have restarted the network with/without cleanup, "Restart Required" is still "Yes"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services