You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/02/27 23:19:55 UTC
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6171
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
---
M be/src/exec/topn-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/6171/1
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
Patch Set 1: Code-Review+2
This fix looks good but see my comment on the JIRA - it may make sense to switch to the sort operator when limit + offset is large since there are other potential problems with the TopN node in those cases
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6171
to look at the new patch set (#2).
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
To test this, Matt Mulder ran the failing query from IMPALA-4995 on a
private cluster and it did not crash. However the query did not finish
within several hours. We should switch to using the Sorter for large
TopN queries, as tracked by IMPALA-5004.
Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
---
M be/src/exec/topn-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/6171/2
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/318/
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
To test this, Matt Mulder ran the failing query from IMPALA-4995 on a
private cluster and it did not crash. However the query did not finish
within several hours. We should switch to using the Sorter for large
TopN queries, as tracked by IMPALA-5004.
Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Reviewed-on: http://gerrit.cloudera.org:8080/6171
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/topn-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Lars Volker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
Patch Set 2: Code-Review+2
Updated commit message, carrying Tim's +2.
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No