[GitHub] [kafka] dengziming commented on a change in pull request #11321: MINOR: Replace EasyMock with Mockito in connect:basic-auth-extension

[GitBox <gi...@apache.org>]

dengziming commented on a change in pull request #11321:
URL: https://github.com/apache/kafka/pull/11321#discussion_r711489402



##########
File path: connect/basic-auth-extension/src/test/java/org/apache/kafka/connect/rest/basic/auth/extension/BasicAuthSecurityRestExtensionTest.java
##########
@@ -55,20 +58,21 @@ public void tearDown() {
     @SuppressWarnings("unchecked")
     @Test
     public void testJaasConfigurationNotOverwritten() {
-        Capture<JaasBasicAuthFilter> jaasFilter = EasyMock.newCapture();
-        Configurable<? extends Configurable<?>> configurable = EasyMock.mock(Configurable.class);
-        EasyMock.expect(configurable.register(EasyMock.capture(jaasFilter))).andReturn(null);
-  
-        ConnectRestExtensionContext context = EasyMock.mock(ConnectRestExtensionContext.class);
-        EasyMock.expect(context.configurable()).andReturn((Configurable) configurable);
-
-        EasyMock.replay(configurable, context);
-  
+        ArgumentCaptor<JaasBasicAuthFilter> jaasFilter = ArgumentCaptor.forClass(JaasBasicAuthFilter.class);
+        Configurable<? extends Configurable<?>> configurable = mock(Configurable.class);
+        when(configurable.register(any())).thenReturn(null);

Review comment:
       Thank you for your reminders, moving captor from`Mockito.verify` to here is simpler.

##########
File path: connect/basic-auth-extension/src/test/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilterTest.java
##########
@@ -53,110 +55,130 @@
     public void testSuccess() throws IOException {
         File credentialFile = setupPropertyLoginFile(true);
         JaasBasicAuthFilter jaasBasicAuthFilter = setupJaasFilter("KafkaConnect", credentialFile.getPath());
-        ContainerRequestContext requestContext = setMock("Basic", "user", "password", false);
+        ContainerRequestContext requestContext = setMock("Basic", "user", "password");
         jaasBasicAuthFilter.filter(requestContext);

Review comment:
       Yes, firstly I think it's good enough to verify `jaasBasicAuthFilter.filter(requestContext)` pass without any exception, after some consideration I think it's better to call `verify` for a double-check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org