[GitHub] [geode] upthewaterspout commented on a change in pull request #7127: GEODE-9669: Improve reporting of Radish mem_fragmentation_ratio

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #7127:
URL: https://github.com/apache/geode/pull/7127#discussion_r758638795



##########
File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/string/AbstractAppendMemoryIntegrationTest.java
##########
@@ -59,7 +60,8 @@ public void testAppend_actuallyIncreasesBucketSize() {
     info = RedisTestHelper.getInfo(jedis);
     Long finalMemValue = Long.valueOf(info.get("used_memory"));
 
-    assertThat(finalMemValue).isGreaterThan(previousMemValue);
+    GeodeAwaitility.await().atMost(Duration.ofSeconds(20))
+        .untilAsserted(() -> assertThat(finalMemValue).isGreaterThan(previousMemValue));

Review comment:
       This test is going to be flaky some of the time. If you happened to sample `used_memory` at a time just before we do a GC, it may take a long time or we may never sample a value of used memory that is less than that value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org