[jira] Commented: (HBASE-2888) Review all our metrics

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907096#action_12907096 ] 

stack commented on HBASE-2888:
------------------------------

Setting hbase.period in hadoop-metrics.properties doesn't seem to have an effect; counts are off.  Here's what I noticed digging in code:

'hadoop-metrics.properties' gets read up into a metrics attributes map but nothing seems to be done w/ them subsequently. Reading up in hadoop, in branch-0.20/src/core/org/apache/hadoop/metrics/package.html, it seems to imply that we need to getAttribute and set them after we make a metrics Context; i.e. in this case, call setPeriod in RegionServerMetrics, etc.?

More broadly, need to make sure settings in hadoop-metrics.properties take effect when changed.

> Review all our metrics
> ----------------------
>
>                 Key: HBASE-2888
>                 URL: https://issues.apache.org/jira/browse/HBASE-2888
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.90.0
>
>
> HBase publishes a bunch of metrics, some useful some wasteful, that should be improved to deliver a better ops experience. Examples:
>  - Block cache hit ratio converges at some point and stops moving
>  - fsReadLatency goes down when compactions are running
>  - storefileIndexSizeMB is the exact same number once a system is serving production load
> We could use new metrics too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.