You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 01:30:55 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #26824: [SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory

HyukjinKwon commented on a change in pull request #26824: [SPARK-30197][PYSPARK] Add minimum `requirements.txt` file to `python` directory
URL: https://github.com/apache/spark/pull/26824#discussion_r355803484
 
 

 ##########
 File path: python/requirements.txt
 ##########
 @@ -0,0 +1,4 @@
+numpy==1.16.4
+scipy==1.2.2
+pandas==0.23.2
+pyarrow==0.15.1
 
 Review comment:
   @dongjoon-hyun how about we put this in https://github.com/apache/spark/blob/master/dev/requirements.txt since these are optional dependencies (and we can say it's needed for the dev?)
   
   ```
   # ML/MLlib
   numpy>=1.7
   scipy>=1.2.2
   # SQL
   pandas>=0.23.2
   pyarrow>=0.15.1
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org