You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/19 16:18:09 UTC

[GitHub] sijie commented on a change in pull request #1275: Fix ByteBuf leaking at Journal

sijie commented on a change in pull request #1275: Fix ByteBuf leaking at Journal
URL: https://github.com/apache/bookkeeper/pull/1275#discussion_r175495090
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
 ##########
 @@ -1089,8 +1093,6 @@ public void run() {
                 numEntriesToFlush++;
                 qe = null;
             }
-            logFile.close();
 
 Review comment:
   They are closed at the finally block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services