You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/09/14 09:37:25 UTC
Review Request 38345: RANGER-632 : [UI Patch] Policy validation error
messages produced by the server are not seen by the user
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38345/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-632
https://issues.apache.org/jira/browse/RANGER-632
Repository: ranger
Description
-------
Ranger UI changes to show error codes and user friendly error messages.
Diffs
-----
security-admin/src/main/webapp/scripts/utils/XAUtils.js 6d84d1c
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 7370ee8
security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 01141b6
Diff: https://reviews.apache.org/r/38345/diff/
Testing
-------
Tested on local Ranger setup for few scenarios like:
- duplicate policy
- policy already exist for a resource
- duplicate service
Thanks,
Gautam Borad
Re: Review Request 38345: RANGER-632 : [UI Patch] Policy validation
error messages produced by the server are not seen by the user
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38345/#review99243
-----------------------------------------------------------
Ship it!
Ship It!
- Alok Lal
On Sept. 16, 2015, 1:39 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38345/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 1:39 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger UI changes to show error codes and user friendly error messages.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/libs/bower/bootstrap-notify/js/bootstrap-notify.js e58c6c5
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 6d84d1c
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 7370ee8
> security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 01141b6
> security-admin/src/main/webapp/styles/xa.css ceb1f53
>
> Diff: https://reviews.apache.org/r/38345/diff/
>
>
> Testing
> -------
>
> Tested on local Ranger setup for few scenarios like:
>
> - duplicate policy
> - policy already exist for a resource
> - duplicate service
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38345: RANGER-632 : [UI Patch] Policy validation
error messages produced by the server are not seen by the user
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38345/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 8:39 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Added pause option in bootstrap notification plugin
Bugs: RANGER-632
https://issues.apache.org/jira/browse/RANGER-632
Repository: ranger
Description
-------
Ranger UI changes to show error codes and user friendly error messages.
Diffs (updated)
-----
security-admin/src/main/webapp/libs/bower/bootstrap-notify/js/bootstrap-notify.js e58c6c5
security-admin/src/main/webapp/scripts/utils/XAUtils.js 6d84d1c
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 7370ee8
security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 01141b6
security-admin/src/main/webapp/styles/xa.css ceb1f53
Diff: https://reviews.apache.org/r/38345/diff/
Testing
-------
Tested on local Ranger setup for few scenarios like:
- duplicate policy
- policy already exist for a resource
- duplicate service
Thanks,
Gautam Borad
Re: Review Request 38345: RANGER-632 : [UI Patch] Policy validation
error messages produced by the server are not seen by the user
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38345/#review98859
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Sept. 14, 2015, 7:37 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38345/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 7:37 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger UI changes to show error codes and user friendly error messages.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 6d84d1c
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 7370ee8
> security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 01141b6
>
> Diff: https://reviews.apache.org/r/38345/diff/
>
>
> Testing
> -------
>
> Tested on local Ranger setup for few scenarios like:
>
> - duplicate policy
> - policy already exist for a resource
> - duplicate service
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38345: RANGER-632 : [UI Patch] Policy validation
error messages produced by the server are not seen by the user
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38345/#review98989
-----------------------------------------------------------
There is a lot more information in that error message now. It clears the screen too fast. Either can should increase the amount of time for which it stays on the screen. Or does it make sense to ask user for a prompt before we clear out the error messages?
- Alok Lal
On Sept. 14, 2015, 12:37 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38345/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 12:37 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger UI changes to show error codes and user friendly error messages.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 6d84d1c
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js 7370ee8
> security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js 01141b6
>
> Diff: https://reviews.apache.org/r/38345/diff/
>
>
> Testing
> -------
>
> Tested on local Ranger setup for few scenarios like:
>
> - duplicate policy
> - policy already exist for a resource
> - duplicate service
>
>
> Thanks,
>
> Gautam Borad
>
>