You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/08/07 14:24:16 UTC
[GitHub] [incubator-linkis] QuintinTao opened a new pull request, #2620: add test case for shell engine
QuintinTao opened a new pull request, #2620:
URL: https://github.com/apache/incubator-linkis/pull/2620
- Added tests case for shell engine.
- 增加shell 引擎的测试用例
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] QuintinTao commented on a diff in pull request #2620: add test case for shell engine
Posted by GitBox <gi...@apache.org>.
QuintinTao commented on code in PR #2620:
URL: https://github.com/apache/incubator-linkis/pull/2620#discussion_r939823386
##########
linkis-engineconn-plugins/shell/src/test/scala/org/apache/linkis/manager/engineplugin/shell/executor/TestShellEngineConnExecutor.scala:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.linkis.manager.engineplugin.shell.executor
+import org.apache.linkis.DataWorkCloudApplication
+import org.apache.linkis.common.conf.DWCArgumentsParser
+import org.apache.linkis.common.utils.Utils
+import org.apache.linkis.engineconn.computation.executor.execute.EngineExecutionContext
+import org.junit.jupiter.api.{Assertions, Test}
+import scala.collection.mutable
+
+class TestShellEngineConnExecutor {
+ @Test
+ def testShellEngineConnExecutor: Unit = {
+ val isWindows = System.getProperty("os.name").startsWith("Windows")
+
+ System.setProperty("wds.linkis.server.version", "v1")
+ System.setProperty("wds.linkis.engineconn.plugin.default.class", "org.apache.linkis.manager.engineplugin.shell.ShellEngineConnPlugin")
+ val map = new mutable.HashMap[String, String]()
+ map.put("spring.mvc.servlet.path", "/api/rest_j/v1")
+ map.put("server.port", "26380")
+ map.put("spring.application.name", "SparkSqlExecutor")
Review Comment:
got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2620: add test case for shell engine
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2620:
URL: https://github.com/apache/incubator-linkis/pull/2620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2620: add test case for shell engine
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2620:
URL: https://github.com/apache/incubator-linkis/pull/2620#issuecomment-1207424831
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2620?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2620](https://codecov.io/gh/apache/incubator-linkis/pull/2620?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7acadd3) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/b4ae904e7dbb81dc627097afaf6b4cc55c055d47?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4ae904) will **increase** coverage by `0.29%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2620 +/- ##
===============================================
+ Coverage 14.45% 14.74% +0.29%
- Complexity 1122 1163 +41
===============================================
Files 732 740 +8
Lines 22974 23217 +243
Branches 3398 3437 +39
===============================================
+ Hits 3320 3423 +103
- Misses 19210 19330 +120
- Partials 444 464 +20
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/linkis/scheduler/queue/SchedulerEvent.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvU2NoZWR1bGVyRXZlbnQuc2NhbGE=) | `52.94% <0.00%> (ø)` | |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `35.55% <0.00%> (ø)` | |
| [...eplugin/shell/factory/ShellEngineConnFactory.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9mYWN0b3J5L1NoZWxsRW5naW5lQ29ubkZhY3Rvcnkuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...gineplugin/shell/executor/YarnAppIdExtractor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9leGVjdXRvci9ZYXJuQXBwSWRFeHRyYWN0b3Iuc2NhbGE=) | `33.96% <0.00%> (ø)` | |
| [...ger/engineplugin/shell/ShellEngineConnPlugin.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9TaGVsbEVuZ2luZUNvbm5QbHVnaW4uc2NhbGE=) | `72.22% <0.00%> (ø)` | |
| [...lugin/shell/executor/ShellEngineConnExecutor.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9leGVjdXRvci9TaGVsbEVuZ2luZUNvbm5FeGVjdXRvci5zY2FsYQ==) | `39.70% <0.00%> (ø)` | |
| [...lugin/shell/executor/ErrorStreamReaderThread.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9leGVjdXRvci9FcnJvclN0cmVhbVJlYWRlclRocmVhZC5zY2FsYQ==) | `34.61% <0.00%> (ø)` | |
| [...lugin/shell/exception/NoCorrectUserException.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9leGNlcHRpb24vTm9Db3JyZWN0VXNlckV4Y2VwdGlvbi5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../builder/ShellProcessEngineConnLaunchBuilder.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9idWlsZGVyL1NoZWxsUHJvY2Vzc0VuZ2luZUNvbm5MYXVuY2hCdWlsZGVyLnNjYWxh) | `100.00% <0.00%> (ø)` | |
| [...neplugin/shell/common/ShellEnginePluginConst.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWVuZ2luZWNvbm4tcGx1Z2lucy9zaGVsbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9tYW5hZ2VyL2VuZ2luZXBsdWdpbi9zaGVsbC9jb21tb24vU2hlbGxFbmdpbmVQbHVnaW5Db25zdC5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-linkis/pull/2620/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #2620: add test case for shell engine
Posted by GitBox <gi...@apache.org>.
peacewong commented on code in PR #2620:
URL: https://github.com/apache/incubator-linkis/pull/2620#discussion_r939794043
##########
linkis-engineconn-plugins/shell/src/test/scala/org/apache/linkis/manager/engineplugin/shell/executor/TestShellEngineConnExecutor.scala:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.linkis.manager.engineplugin.shell.executor
+import org.apache.linkis.DataWorkCloudApplication
+import org.apache.linkis.common.conf.DWCArgumentsParser
+import org.apache.linkis.common.utils.Utils
+import org.apache.linkis.engineconn.computation.executor.execute.EngineExecutionContext
+import org.junit.jupiter.api.{Assertions, Test}
+import scala.collection.mutable
+
+class TestShellEngineConnExecutor {
+ @Test
+ def testShellEngineConnExecutor: Unit = {
+ val isWindows = System.getProperty("os.name").startsWith("Windows")
+
+ System.setProperty("wds.linkis.server.version", "v1")
+ System.setProperty("wds.linkis.engineconn.plugin.default.class", "org.apache.linkis.manager.engineplugin.shell.ShellEngineConnPlugin")
+ val map = new mutable.HashMap[String, String]()
+ map.put("spring.mvc.servlet.path", "/api/rest_j/v1")
+ map.put("server.port", "26380")
+ map.put("spring.application.name", "SparkSqlExecutor")
Review Comment:
should be shell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org